Moodle
  1. Moodle
  2. MDL-29016

Support changing of $CFG->directorypermissions in moodle installers modified by distributions

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.13, 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Installation
    • Labels:
    • Testing Instructions:
      Hide

      1/ create install/distrolib.php with custom permissions
      2/ verify new config.php contains it

      Show
      1/ create install/distrolib.php with custom permissions 2/ verify new config.php contains it
    • Workaround:
      Hide

      1. Ask $INSTALL['directorypermissions']

      2. Use this $INSTALL['directorypermissions'] use as the default for zanachenie $CFG->directorypermissions

      PS: The patch will put later.

      Show
      1. Ask $INSTALL ['directorypermissions'] 2. Use this $INSTALL ['directorypermissions'] use as the default for zanachenie $CFG->directorypermissions PS: The patch will put later.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w33_MDL-29016_m22_distropermissions
    • Rank:
      18711

      Description

      The file install.php default value of $CFG->directorypermissions has more than one times:

      1. When you set fake some settings so that we can use selected functions from moodlelib.php and weblib.php
      2. When you create a config file.

      This makes it hard to write a patch that performs the substitution of the correct default values ​​for $CFG->directorypermissions.

        Activity

        Hide
        Aleksey Avdeev added a comment - - edited

        Patch 0001-MDL-29016-install.php-Use-as-a-INSTALL-directoryperm.patch corresponds brunch ALT/moodle/patch/install-directorypermissions in my git repository (see http://git.altlinux.org/people/solo/packages/moodle.git?p=moodle.git;a=commit;h=71a9cba0285b33c9246085eb04814f8acac6576b).

        This patch is tested, and will be used in the next assembly moodle-1.9 for ALT Linux.

        Show
        Aleksey Avdeev added a comment - - edited Patch 0001- MDL-29016 -install.php-Use-as-a-INSTALL-directoryperm.patch corresponds brunch ALT/moodle/patch/install-directorypermissions in my git repository (see http://git.altlinux.org/people/solo/packages/moodle.git?p=moodle.git;a=commit;h=71a9cba0285b33c9246085eb04814f8acac6576b ). This patch is tested, and will be used in the next assembly moodle-1.9 for ALT Linux.
        Hide
        Aleksey Avdeev added a comment -

        Package moodle-1.9.13.20110817-alt2 (see http://git.altlinux.org/people/solo/packages/moodle.git?p=moodle.git;a=commit;h=77cde220c1f902e8388b7fdb9514165166e8ace3), applying the proposed patch (under the name of moodle-alt-install-directorypermissions.patch), went to the Sisyphus (see http://en.altlinux.org/Sisyphus).

        Show
        Aleksey Avdeev added a comment - Package moodle-1.9.13.20110817-alt2 (see http://git.altlinux.org/people/solo/packages/moodle.git?p=moodle.git;a=commit;h=77cde220c1f902e8388b7fdb9514165166e8ace3 ), applying the proposed patch (under the name of moodle-alt-install-directorypermissions.patch), went to the Sisyphus (see http://en.altlinux.org/Sisyphus ).
        Hide
        Petr Škoda added a comment -

        To integrators: please cherry pick to all 2.x branches

        Show
        Petr Škoda added a comment - To integrators: please cherry pick to all 2.x branches
        Hide
        Petr Škoda added a comment -

        Aleksey: thanks for the idea! I have created a new patch for 2.x, because only critical fixes are now allowed in the 1.9.x branch.

        Show
        Petr Škoda added a comment - Aleksey: thanks for the idea! I have created a new patch for 2.x, because only critical fixes are now allowed in the 1.9.x branch.
        Hide
        Aleksey Avdeev added a comment - - edited

        Petr, thank you - at the 2.

        {0,1}

        of the same patch I also needed. But I plan to do them no earlier than Monday.

        Show
        Aleksey Avdeev added a comment - - edited Petr, thank you - at the 2. {0,1} of the same patch I also needed. But I plan to do them no earlier than Monday.
        Hide
        Petr Škoda added a comment -

        Eloy will do the backporting via cherry picking during the integration, you do not need to do anything more. Thanks again.

        Show
        Petr Škoda added a comment - Eloy will do the backporting via cherry picking during the integration, you do not need to do anything more. Thanks again.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Rajesh Taneja added a comment -

        Works Great.
        Thanks for fixing this Aleksey and Petr

        Show
        Rajesh Taneja added a comment - Works Great. Thanks for fixing this Aleksey and Petr
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: