Moodle
  1. Moodle
  2. MDL-29062

WSD (White screen of Death), while editing "Embedded Question"

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      Steps to reproduce:
      1. Create a new question "Embedded answers (Cloze)"
      2. Type following in "Question text"

      <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p>
      <p>Sub-question 2: {1:MULTICHOICE:%100%Yes~%0%No}</p>
      

      3. Click "Decode and verify the question text"
      4. Click save changes
      5. Now edit this question
      6. Replace "Question text" with

      <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p>
      

      7. Click "Decode and verify the question text"
      8. Confirm "The question will be saved as edited"
      9. Click "Save Changes"
      10. WSD (White screen of death) with above error msg should not be visible

      Show
      Steps to reproduce: 1. Create a new question "Embedded answers (Cloze)" 2. Type following in "Question text" <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p> <p>Sub-question 2: {1:MULTICHOICE:%100%Yes~%0%No}</p> 3. Click "Decode and verify the question text" 4. Click save changes 5. Now edit this question 6. Replace "Question text" with <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p> 7. Click "Decode and verify the question text" 8. Confirm "The question will be saved as edited" 9. Click "Save Changes" 10. WSD (White screen of death) with above error msg should not be visible
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18749

      Description

      While testing MDL-28241, WSD (White screen of Death) was observed. Editing "Embedded Question" show WSD.

      Fatal error: Call to undefined function delete_question() in /usr/local/www/moodle/question/type/multianswer/questiontype.php on line 151 Call Stack: 0.0011 854048 1. {main}() /usr/local/www/moodle/question/question.php:0 0.4490 55037360 2. qtype_multianswer->save_question() /usr/local/www/moodle/question/question.php:264 0.4492 55050896 3. question_type->save_question() /usr/local/www/moodle/question/type/multianswer/questiontype.php:181 0.4753 55121848 4. qtype_multianswer->save_question_options() /usr/local/www/moodle/question/type/questiontypebase.php:424
      

      Steps to reproduce:

      1. Create a new question "Embedded answers (Cloze)"
      2. Type following in "Question text"
        <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p>
        <p>Sub-question 2: {1:MULTICHOICE:%100%Yes~%0%No}</p>
        
      3. Click "Decode and verify the question text"
      4. Click save changes
      5. Now edit this question
      6. Replace "Question text" with
        <p>Sub-question 1: {2:NUMERICAL:=5E-3:1E-4}</p>
        
      7. Click "Decode and verify the question text"
      8. Confirm "The question will be saved as edited"
      9. Click "Save Changes"
      10. WSD (White screen of death) with above error msg will be visible.

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Sam Hemelryk added a comment -

          Testes. Passed. Thanks Tim.

          Just noting again that the same notices mentioned on the other multianswer question are visible here as well. See MDL-29064

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Testes. Passed. Thanks Tim. Just noting again that the same notices mentioned on the other multianswer question are visible here as well. See MDL-29064 Cheers Sam
          Hide
          Eloy Lafuente (stronk7) added a comment -

          git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: