Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29070

Clean enrol_imsenterprise following coding guidelines

    XMLWordPrintable

Details

    • Task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.4, 2.1.1, 2.2, 2.4.6, 2.5.2
    • 2.6
    • Libraries
    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_26_STABLE
    • MDL-29070-master
    • Hide
      1. Download the attached IMS enterprise enrolment file and put it in your moodledata directory
      2. Go to Home / Site administration / Plugins / Enrolments
      3. Enable the IMS enterprise enrolment plugin
      4. In the settings, provide the path to the file you uploaded in File location
      5. Save settings
      6. Go to the link 'perform an IMS Enterprise import right now'
      7. VERIFY: the ims enrollment works ok (courses are created)
      8. VERIFY: no debugging is experienced
      9. Run the phpunit tests
      Show
      Download the attached IMS enterprise enrolment file and put it in your moodledata directory Go to Home / Site administration / Plugins / Enrolments Enable the IMS enterprise enrolment plugin In the settings, provide the path to the file you uploaded in File location Save settings Go to the link 'perform an IMS Enterprise import right now' VERIFY: the ims enrollment works ok (courses are created) VERIFY: no debugging is experienced Run the phpunit tests
    • 3

    Description

      While reviewing MDL-28962 I detected that enrol/imsenterprise/lib.php is one of the worst files I've seen from the POV of Moodle coding guidelines (spaces, comments..., if/loop...).

      I think it would be great to perform a general cleanup for it. For your consideration if only dev or all 2.x stable branches too (note that, right now the file is 100% the same in 20, 21 and master). I'm sending this to STABLE backlog initially.

      Ciao

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50092 User unenrollment not working with IMS Enterprise

          • Minor - Minor loss of function where workaround is possible
          • Closed
          will help resolve

          New Feature - A new Moodle feature which has yet to be developed. MDL-31356 IMS Enterprise enrol plugin added features

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-37185 cleanup enrol_imsenterprise

          • Major - Major loss of function, incorrect output
          • Closed

          Activity

            People

              poltawski Dan Poltawski
              stronk7 Eloy Lafuente (stronk7)
              Ankit Agarwal Ankit Agarwal
              Damyon Wiese Damyon Wiese
              Jason Fowler Jason Fowler
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                18/Nov/13