Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29115

Provide option to try a question again

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1
    • Fix Version/s: 2.0.6, 2.1.3
    • Component/s: Lesson
    • Labels:
    • Testing Instructions:
      Hide

      In Moodle 2.0 or 2.1
      Create a Lesson with a couple of MCQ questions.
      ---------
      Lesson settings: Flow control
      Allow student review NO
      Provide option to try a question again NO
      Maximum number of attempts 1
      Display default feedback YES
      --------
      Log in as student and do the lesson.
      Select incorrect answer for Q1
      Lesson displays 2 buttons:
      Yes, I'd like to try again and Continue.
      --------
      Since the Provide option to try a question again is set to NO, this should NOT happen, only the Continue button should get displayed!

      Show
      In Moodle 2.0 or 2.1 Create a Lesson with a couple of MCQ questions. --------- Lesson settings: Flow control Allow student review NO Provide option to try a question again NO Maximum number of attempts 1 Display default feedback YES -------- Log in as student and do the lesson. Select incorrect answer for Q1 Lesson displays 2 buttons: Yes, I'd like to try again and Continue. -------- Since the Provide option to try a question again is set to NO, this should NOT happen, only the Continue button should get displayed!
    • Workaround:
      Hide

      No workaround, but see my suggested fix in the Description field above.

      Show
      No workaround, but see my suggested fix in the Description field above.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      The way that those two Lesson settings: Provide option to try a question again and Maximum number of attempts interact leads to inconsistencies in the Lesson flow control.

      see this forum discussion:http://moodle.org/mod/forum/discuss.php?d=183756

      I have found a simple fix, which does work in the case at hand, but may have unexpected side-effects, so use at own risk.

      For Moodle 2.0 and 2.1. In file <moodle>/mod/lesson/continue.php, change line 200 from:

       if (!$result->correctanswer && !$result->noanswer && !$result->isessayquestion && !$reviewmode) {

      to

       if (!$result->correctanswer && !$result->noanswer && !$result->isessayquestion && !$reviewmode && $lesson->review) {

        Attachments

          Activity

            People

            Assignee:
            rwijaya Rossiani Wijaya
            Reporter:
            rezeau Joseph Rézeau
            Peer reviewer:
            Ankit Agarwal Ankit Agarwal
            Integrator:
            Sam Hemelryk Sam Hemelryk
            Tester:
            Sam Hemelryk Sam Hemelryk
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            4 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/Nov/11