Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0, 2.1
-
Component/s: Lesson
-
Labels:
-
Testing Instructions:
-
Workaround:
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
The way that those two Lesson settings: Provide option to try a question again and Maximum number of attempts interact leads to inconsistencies in the Lesson flow control.
see this forum discussion:http://moodle.org/mod/forum/discuss.php?d=183756
I have found a simple fix, which does work in the case at hand, but may have unexpected side-effects, so use at own risk.
For Moodle 2.0 and 2.1. In file <moodle>/mod/lesson/continue.php, change line 200 from:
if (!$result->correctanswer && !$result->noanswer && !$result->isessayquestion && !$reviewmode) {
|
to
if (!$result->correctanswer && !$result->noanswer && !$result->isessayquestion && !$reviewmode && $lesson->review) {
|
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Hello Rossiani, there are possibilities to speed up a resolution for this? It is affecting some production sites where Lesson module is used.
Hi Joseph ,
Thanks for providing solution to the issue.
Andrea,
I just created a patch for integration review and hopefully it could be part of this week integration.
Looks good to me!
Thanks
Hello, there are chances for integration this week ?
Pushing this for integration review.
Thanks Rosie this has been integrated now 
Tested during integration review
And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!
Ciao
This issue (or similar issue) still exists in v.2.3.x and v2.5. I could reproduce this on the demo.moodle.net site as well.
When Provide option to try a question again set to No and Max number of attempts is greater than 1, students can attempt the question as many times as set in Max attempts. The Provide option to try a question again setting is completely ignored.
Current workaround is to set Max number of attempts to 1 when setting Provide option to try a question again to No.
This not a very good workaround as teachers can easily fail to do this.
A simple hack that works is to add the following condition in lesson_update_instance() in /mod/lesson/lib.php:
if($data->review == 0) // cannot retry question, so only 1 attempt
{
$data->maxattempts = 1;
}
This sets max attempts to 1 if no retry option is available.
Probably a better patch will be to not allow this condition to occur in the first place. Max number of attempts should be disabled and set to 1 when retry question option is set to No in mod_form.php
BUMP ! any progress on this?