Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.0.8, 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      The latest (8-22-11) Xampp stack on a fully updated Windows 7 box
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Here is the process I followed:
      Fresh install of 2.1.1 (system level highlight unread forum posts is checked by default)
      Keep the default Standard theme
      Create users A and B (set each user's profile to highlight unread forum posts)
      Create a class
      Create forum 1
      Post as user A in forum 1
      View forum 1 as user B

      What should happen
      User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. This works in Standard

      Switch theme to Formal White
      Post as user A in forum 1
      View forum 1 as user B

      What should happen
      User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. In the Formal White them, and all other themes I tested (although I did not test all of them), the highlighting works on the course page but does not work on the forum page or the thread page.

      Show
      Here is the process I followed: Fresh install of 2.1.1 (system level highlight unread forum posts is checked by default) Keep the default Standard theme Create users A and B (set each user's profile to highlight unread forum posts) Create a class Create forum 1 Post as user A in forum 1 View forum 1 as user B What should happen User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. This works in Standard Switch theme to Formal White Post as user A in forum 1 View forum 1 as user B What should happen User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. In the Formal White them, and all other themes I tested (although I did not test all of them), the highlighting works on the course page but does not work on the forum page or the thread page.
    • Workaround:
      Hide

      The following code can be inserted into any theme's core.css to fix the problem. Or, the code can be inserted into /theme/base/style/core.css to fix all themes. Be sure to clear your theme cache to have the change take effect.

      Two observations:
      (1)This code does not belong in core.css, so this is a temporary fix
      (2)The colors below fit the Formal White theme, but are not ideal generic colors for all the themes.

      /mod by to fix forum highlighting/
      .unread

      {background: #ECBC6A;}

      /unread column on forum page/
      .path-course-view .unread

      {background:#ECBC6A;}

      /unread number next to forum on course page/
      .forumpost.unread

      {background: #F8E5C4;}

      /*unread post background */
      .forumpost.unread .content

      {border:2px solid #D88A00;}

      /unread post border/
      /end mod/

      Show
      The following code can be inserted into any theme's core.css to fix the problem. Or, the code can be inserted into /theme/base/style/core.css to fix all themes. Be sure to clear your theme cache to have the change take effect. Two observations: (1)This code does not belong in core.css, so this is a temporary fix (2)The colors below fit the Formal White theme, but are not ideal generic colors for all the themes. / mod by to fix forum highlighting / .unread {background: #ECBC6A;} / unread column on forum page / .path-course-view .unread {background:#ECBC6A;} / unread number next to forum on course page / .forumpost.unread {background: #F8E5C4;} /*unread post background */ .forumpost.unread .content {border:2px solid #D88A00;} / unread post border / / end mod /
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29127_master

      Description

      Version 2.1.1 (probably effects all 2.x.x, but I did not test other versions)

      Unread forum posts (new posts) are highlighted correctly in the Standard theme, but not in other themes. This is a CSS problem. The Standard theme defines the following classes, but the other provided themes do not define these class. Neither Base nor Core define these classes either.

      .path-course-view .unread (defined in \theme\standard\style\course.css)
      .forumpost.unread (defined in \theme\standard\style\modules.css)
      .forumpost.unread .content (defined in \theme\standard\style\modules.css)

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12