Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.0.8, 2.1.5, 2.2.2
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      The latest (8-22-11) Xampp stack on a fully updated Windows 7 box
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Here is the process I followed:
      Fresh install of 2.1.1 (system level highlight unread forum posts is checked by default)
      Keep the default Standard theme
      Create users A and B (set each user's profile to highlight unread forum posts)
      Create a class
      Create forum 1
      Post as user A in forum 1
      View forum 1 as user B

      What should happen
      User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. This works in Standard

      Switch theme to Formal White
      Post as user A in forum 1
      View forum 1 as user B

      What should happen
      User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. In the Formal White them, and all other themes I tested (although I did not test all of them), the highlighting works on the course page but does not work on the forum page or the thread page.

      Show
      Here is the process I followed: Fresh install of 2.1.1 (system level highlight unread forum posts is checked by default) Keep the default Standard theme Create users A and B (set each user's profile to highlight unread forum posts) Create a class Create forum 1 Post as user A in forum 1 View forum 1 as user B What should happen User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. This works in Standard Switch theme to Formal White Post as user A in forum 1 View forum 1 as user B What should happen User B should see that they have 1 unread post in forum 1. This should be highlighted on the course page, on the forum page, and then the post should be highlighted in the thread page. In the Formal White them, and all other themes I tested (although I did not test all of them), the highlighting works on the course page but does not work on the forum page or the thread page.
    • Workaround:
      Hide

      The following code can be inserted into any theme's core.css to fix the problem. Or, the code can be inserted into /theme/base/style/core.css to fix all themes. Be sure to clear your theme cache to have the change take effect.

      Two observations:
      (1)This code does not belong in core.css, so this is a temporary fix
      (2)The colors below fit the Formal White theme, but are not ideal generic colors for all the themes.

      /mod by to fix forum highlighting/
      .unread

      {background: #ECBC6A;}

      /unread column on forum page/
      .path-course-view .unread

      {background:#ECBC6A;}

      /unread number next to forum on course page/
      .forumpost.unread

      {background: #F8E5C4;}

      /*unread post background */
      .forumpost.unread .content

      {border:2px solid #D88A00;}

      /unread post border/
      /end mod/

      Show
      The following code can be inserted into any theme's core.css to fix the problem. Or, the code can be inserted into /theme/base/style/core.css to fix all themes. Be sure to clear your theme cache to have the change take effect. Two observations: (1)This code does not belong in core.css, so this is a temporary fix (2)The colors below fit the Formal White theme, but are not ideal generic colors for all the themes. / mod by to fix forum highlighting / .unread {background: #ECBC6A;} / unread column on forum page / .path-course-view .unread {background:#ECBC6A;} / unread number next to forum on course page / .forumpost.unread {background: #F8E5C4;} /*unread post background */ .forumpost.unread .content {border:2px solid #D88A00;} / unread post border / / end mod /
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29127_master

      Description

      Version 2.1.1 (probably effects all 2.x.x, but I did not test other versions)

      Unread forum posts (new posts) are highlighted correctly in the Standard theme, but not in other themes. This is a CSS problem. The Standard theme defines the following classes, but the other provided themes do not define these class. Neither Base nor Core define these classes either.

      .path-course-view .unread (defined in \theme\standard\style\course.css)
      .forumpost.unread (defined in \theme\standard\style\modules.css)
      .forumpost.unread .content (defined in \theme\standard\style\modules.css)

        Gliffy Diagrams

          Activity

          estraw Eric Straw created issue -
          Hide
          lazydaisy Mary Evans added a comment -

          @Daniele,

          I've just come across this MDL which had been automatically assigned to Patrick, but as Patrick has asked me to re-assign them for him, so I am passing this on to you Daniele. Can you add this in when you next update Formal White? Thanks
          Mary

          Show
          lazydaisy Mary Evans added a comment - @Daniele, I've just come across this MDL which had been automatically assigned to Patrick, but as Patrick has asked me to re-assign them for him, so I am passing this on to you Daniele. Can you add this in when you next update Formal White? Thanks Mary
          lazydaisy Mary Evans made changes -
          Field Original Value New Value
          Assignee Patrick Malley [ ptrkmkl ] Daniele Cordella [ daniss ]
          daniss Daniele Cordella made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/kordan/moodle/compare/master...MDL-29127_master
          Pull Master Branch MDL-29127_master
          Pull 2.0 Diff URL https://github.com/kordan/moodle/compare/MOODLE_20_STABLE...MDL-29127_M20
          Pull from Repository git://github.com/kordan/moodle.git
          Pull 2.0 Branch MDL-29127_M20
          Fix Version/s STABLE Sprint 17 [ 11550 ]
          Pull 2.1 Branch MDL-29127_M21
          Pull 2.2 Diff URL https://github.com/kordan/moodle/compare/MOODLE_22_STABLE...MDL-29127_M22
          Pull 2.1 Diff URL https://github.com/kordan/moodle/compare/MOODLE_21_STABLE...MDL-29127_M21
          Pull 2.2 Branch MDL-29127_M22
          Hide
          daniss Daniele Cordella added a comment -

          Mary, thanks for your call.
          I updated the theme. I hope all is fine.
          The patch really is as simple as silly.
          Feel free to add your comments if you find something than can be done in a better way.
          Ciao.

          Show
          daniss Daniele Cordella added a comment - Mary, thanks for your call. I updated the theme. I hope all is fine. The patch really is as simple as silly. Feel free to add your comments if you find something than can be done in a better way. Ciao.
          daniss Daniele Cordella made changes -
          Fix Version/s STABLE backlog [ 10463 ]
          Fix Version/s STABLE Sprint 17 [ 11550 ]
          stronk7 Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          stronk7 Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes [ 10041 ]
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          samhemelryk Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          samhemelryk Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Daniele,
          I've integrated this now. Once again I cherry-picked and edited your commits as you'd forgotten to include the tracker number in the commit message. Otherwise fine though

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Daniele, I've integrated this now. Once again I cherry-picked and edited your commits as you'd forgotten to include the tracker number in the commit message. Otherwise fine though Cheers Sam
          samhemelryk Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s 2.0.8 [ 11554 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s STABLE backlog [ 10463 ]
          salvetore Michael de Raadt made changes -
          Tester rwijaya
          rwijaya Rossiani Wijaya made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Hi Daniele,

          The patch seems to fixed the formal_white theme only. The issue still occurs in other themes.

          Will the rest of themes be fixed on separate issue?

          Show
          rwijaya Rossiani Wijaya added a comment - Hi Daniele, The patch seems to fixed the formal_white theme only. The issue still occurs in other themes. Will the rest of themes be fixed on separate issue?
          Hide
          daniss Daniele Cordella added a comment -

          Ciao Rossiani
          as Mary asked on 15/set/11 11:13 PM
          I wrote the patch for formal white ONLY.
          Maybe the right person to ask for this question is Patrick or Mary or someone else but me.
          I really do not know even if I think, as you think, it should be applied to all the rest of themes.
          Should it be filed a new more general issue for this purpose? Who is responsible for this kind of decisions?

          Show
          daniss Daniele Cordella added a comment - Ciao Rossiani as Mary asked on 15/set/11 11:13 PM I wrote the patch for formal white ONLY. Maybe the right person to ask for this question is Patrick or Mary or someone else but me. I really do not know even if I think, as you think, it should be applied to all the rest of themes. Should it be filed a new more general issue for this purpose? Who is responsible for this kind of decisions?
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Oops, I asked the wrong person. I just read your name as assignee and assumed you are working on this.

          Mary or Patrick,
          Any input regarding this?

          Show
          rwijaya Rossiani Wijaya added a comment - Oops, I asked the wrong person. I just read your name as assignee and assumed you are working on this. Mary or Patrick, Any input regarding this?
          Hide
          daniss Daniele Cordella added a comment -

          Mary

          Show
          daniss Daniele Cordella added a comment - Mary
          Hide
          lazydaisy Mary Evans added a comment -

          Ciao Daniele, I am tempted to say...
          "Daniele non posso perdere tempo con queste cose banali"
          but I fear that this is NOT the Moodle way to do things, so I shall sort this one out.
          Thanks for fixing Formal White...it's looking great!

          Show
          lazydaisy Mary Evans added a comment - Ciao Daniele, I am tempted to say... "Daniele non posso perdere tempo con queste cose banali" but I fear that this is NOT the Moodle way to do things, so I shall sort this one out. Thanks for fixing Formal White...it's looking great!
          lazydaisy Mary Evans made changes -
          Summary Unread forum posts are NOT being highlighted Unread forum posts are NOT being highlighted in Formal White
          lazydaisy Mary Evans made changes -
          Parent MDL-31934 [ 51646 ]
          Rank (Obsolete) 172180000000
          Issue Type Bug [ 1 ] Sub-task [ 5 ]
          Hide
          lazydaisy Mary Evans added a comment -

          Ecco!

          I have changed the name of this issue to make it a Formal White only fix.
          I have also opened MDL-31934 to deal with all CORE themes and made MDL-29127 a Sub-Task of it.
          This should keep things together.

          grazie mille
          Ciao
          Mary

          Show
          lazydaisy Mary Evans added a comment - Ecco! I have changed the name of this issue to make it a Formal White only fix. I have also opened MDL-31934 to deal with all CORE themes and made MDL-29127 a Sub-Task of it. This should keep things together. grazie mille Ciao Mary
          Hide
          rwijaya Rossiani Wijaya added a comment -

          Thanks Mary!

          Passing this issue for fixing formal white only. The rest of themes will be fixed on MDL-31934.

          Test passed.

          Show
          rwijaya Rossiani Wijaya added a comment - Thanks Mary! Passing this issue for fixing formal white only. The rest of themes will be fixed on MDL-31934 . Test passed.
          rwijaya Rossiani Wijaya made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

          icao_reverse('arreis olik rebemevon afla letoh ognat');

          Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao
          stronk7 Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 09/Mar/12
          Subversion JIRA

          Links Hierarchy

           Documentation

          Invalid license: EXPIRED

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Mar/12