Moodle
  1. Moodle
  2. MDL-29129

unlocalized strings in wiki

        Details

        • Testing Instructions:
          Hide

          1. Create a wiki.
          2. Create some pages beyond the initial page.
          3. Visit the administration tab.
          4. Make sure that "Remove pages" is selected.
          5. Verify that the table at left which lists pages is headed "Page name".

          Show
          1. Create a wiki. 2. Create some pages beyond the initial page. 3. Visit the administration tab. 4. Make sure that "Remove pages" is selected. 5. Verify that the table at left which lists pages is headed "Page name".
        • Affected Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
        • Fixed Branches:
          MOODLE_22_STABLE, MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-29129-master
        • Pull Master Diff URL:

          Description

          There are two unlocalized strings in wiki 2:

          Table of contents
          [edit]

          Both of them are hardcoded in mod/wiki/parser/markups/wikimarkup.php

            Gliffy Diagrams

              Issue Links

              will be (partly) resolved by

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32023 Hard coded lang strings in wiki module, missing lang strings

              • Major - Major loss of function, incorrect output
              • Closed

              Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31201 The string 'Table of contents' can not be translated

              • Minor - Minor loss of function where workaround is possible
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Sunner Sun added a comment -

                Another unlocalized string, "Page name":

                mod/wiki/pagelib.php: $table->head = array('','Page name');

                Show
                Sunner Sun added a comment - Another unlocalized string, "Page name": mod/wiki/pagelib.php: $table->head = array('','Page name');
                Hide
                Permalink
                Charles Fulton added a comment -

                Patch for the third string; the other two are addressed in separate issues which I'll link.

                Show
                Charles Fulton added a comment - Patch for the third string; the other two are addressed in separate issues which I'll link.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Hi Charles,

                Looks good, a trivial thing is that it'd be good to have a space between , and the get_string call (despite the previous code not having it).

                Submitting it for integration, if you could put some basic testing instructions on how to check this it'd be great.

                thanks!
                dan

                Show
                Dan Poltawski added a comment - Hi Charles, Looks good, a trivial thing is that it'd be good to have a space between , and the get_string call (despite the previous code not having it). Submitting it for integration, if you could put some basic testing instructions on how to check this it'd be great. thanks! dan
                Hide
                Permalink
                Charles Fulton added a comment -

                Done and done.

                Show
                Charles Fulton added a comment - Done and done.
                Hide
                Permalink
                Dan Poltawski added a comment -

                The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

                TIA and ciao

                Show
                Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
                Hide
                Permalink
                Charles Fulton added a comment -

                Rebased.

                Show
                Charles Fulton added a comment - Rebased.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Integrated (22, 23 & master), thanks!

                Show
                Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
                Hide
                Permalink
                Tim Barker added a comment -

                Congratulations the test passed!

                Show
                Tim Barker added a comment - Congratulations the test passed!
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                Fixed STOP Closed STOP Thanks STOP

                Yay, imagination! Ciao

                Show
                Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

                  People

                  • Votes:
                    1 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: