Details

    • Testing Instructions:
      Hide

      1. Create a wiki.
      2. Create some pages beyond the initial page.
      3. Visit the administration tab.
      4. Make sure that "Remove pages" is selected.
      5. Verify that the table at left which lists pages is headed "Page name".

      Show
      1. Create a wiki. 2. Create some pages beyond the initial page. 3. Visit the administration tab. 4. Make sure that "Remove pages" is selected. 5. Verify that the table at left which lists pages is headed "Page name".
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29129-master
    • Rank:
      18670

      Description

      There are two unlocalized strings in wiki 2:

      Table of contents
      [edit]

      Both of them are hardcoded in mod/wiki/parser/markups/wikimarkup.php

        Issue Links

          Activity

          Hide
          Sunner Sun added a comment -

          Another unlocalized string, "Page name":

          mod/wiki/pagelib.php: $table->head = array('','Page name');

          Show
          Sunner Sun added a comment - Another unlocalized string, "Page name": mod/wiki/pagelib.php: $table->head = array('','Page name');
          Hide
          Charles Fulton added a comment -

          Patch for the third string; the other two are addressed in separate issues which I'll link.

          Show
          Charles Fulton added a comment - Patch for the third string; the other two are addressed in separate issues which I'll link.
          Hide
          Dan Poltawski added a comment -

          Hi Charles,

          Looks good, a trivial thing is that it'd be good to have a space between , and the get_string call (despite the previous code not having it).

          Submitting it for integration, if you could put some basic testing instructions on how to check this it'd be great.

          thanks!
          dan

          Show
          Dan Poltawski added a comment - Hi Charles, Looks good, a trivial thing is that it'd be good to have a space between , and the get_string call (despite the previous code not having it). Submitting it for integration, if you could put some basic testing instructions on how to check this it'd be great. thanks! dan
          Hide
          Charles Fulton added a comment -

          Done and done.

          Show
          Charles Fulton added a comment - Done and done.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Charles Fulton added a comment -

          Rebased.

          Show
          Charles Fulton added a comment - Rebased.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (22, 23 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
          Hide
          Tim Barker added a comment -

          Congratulations the test passed!

          Show
          Tim Barker added a comment - Congratulations the test passed!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: