Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29139

/lib/form/recaptcha.php should require parent libraries

    Details

    • Testing Instructions:
      Hide

      Create an mform with only a captcha element
      Test theres no need to require any HTML/Quickform stuff when using recaptcha.

      Show
      Create an mform with only a captcha element Test theres no need to require any HTML/Quickform stuff when using recaptcha.
    • Workaround:
      Hide

      require_once('HTML/QuickForm/input.php');

      Show
      require_once('HTML/QuickForm/input.php');
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When creating a form with only a captcha element (no text fields etc..) we receive the following Fatal error:

      Fatal error:  Class 'HTML_QuickForm_input' not found in /lib/form/recaptcha.php on line 17

      Solution is to require_once('HTML/QuickForm/input.php'); from the top of my script, but clearly this should be handled by /lib/form/recaptcha.php

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            nebgor Aparup Banerjee added a comment -

            This should be a quick fix for the next sprint.

            Show
            nebgor Aparup Banerjee added a comment - This should be a quick fix for the next sprint.
            Hide
            nebgor Aparup Banerjee added a comment -

            hiking up to Major - affecting moodle.org customisation

            Show
            nebgor Aparup Banerjee added a comment - hiking up to Major - affecting moodle.org customisation
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            Zing!

            Show
            jtomkinson Jordan Tomkinson added a comment - Zing!
            Hide
            salvetore Michael de Raadt added a comment -

            Magically pushing this forward through time...

            Show
            salvetore Michael de Raadt added a comment - Magically pushing this forward through time...
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            Zing!

            Show
            jtomkinson Jordan Tomkinson added a comment - Zing!
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Looks Good to me Aparup
            Might be nice, if there is space between require and comment.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Looks Good to me Aparup Might be nice, if there is space between require and comment.
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks for review Raj, change made, this is up for integration.
            Zung!

            Show
            nebgor Aparup Banerjee added a comment - Thanks for review Raj, change made, this is up for integration. Zung!
            Hide
            jtomkinson Jordan Tomkinson added a comment -

            Zing!

            Show
            jtomkinson Jordan Tomkinson added a comment - Zing!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Apu - this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Apu - this has been integrated now
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This works great.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - This works great. Test passed.
            Hide
            nebgor Aparup Banerjee added a comment -

            fixes have been rolled merrily up the stream! Thanks everybody!

            Show
            nebgor Aparup Banerjee added a comment - fixes have been rolled merrily up the stream! Thanks everybody!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11