Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      Run the following command on each patched branch and make sure a single line is returned:

      cat mod/resource/lang/en/resource.php | grep "\['printintroexplain'\] = 'Display resource description below content"

      note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "printintroexplain" string and make sure its value starts with "Display resource description below content" string.

      Show
      Run the following command on each patched branch and make sure a single line is returned: cat mod/resource/lang/en/resource.php | grep "\['printintroexplain'\] = 'Display resource description below content" note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "printintroexplain" string and make sure its value starts with "Display resource description below content" string.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-29153_fix_typo_in_resource

      Description

      Bellow should be changed to below before Moodlers start making loud complaining noises

      $string['printintroexplain'] = 'Display resource description bellow content?

      Feel free to backport to 2.0

      Peace - Anthony

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            tsala Helen Foster added a comment -

            Anthony, thanks for your report. Reassigning to moodle.com.

            Show
            tsala Helen Foster added a comment - Anthony, thanks for your report. Reassigning to moodle.com.
            Hide
            mudrd8mz David Mudrák added a comment -

            I'm on it!

            Show
            mudrd8mz David Mudrák added a comment - I'm on it!
            Hide
            mudrd8mz David Mudrák added a comment -

            Ping for myself so I don't forget to process this next week.

            Show
            mudrd8mz David Mudrák added a comment - Ping for myself so I don't forget to process this next week.
            Hide
            mudrd8mz David Mudrák added a comment -

            Assigning to Gerard to fix this while working on a bulk of other fixes. Thanks in advance.

            Show
            mudrd8mz David Mudrák added a comment - Assigning to Gerard to fix this while working on a bulk of other fixes. Thanks in advance.
            Hide
            gerry Gerard Caulfield added a comment - - edited

            Thanks David. Just wondering why you removed your patch? Was there something wrong with it?

            Show
            gerry Gerard Caulfield added a comment - - edited Thanks David. Just wondering why you removed your patch? Was there something wrong with it?
            Hide
            dobedobedoh Andrew Nicols added a comment -

            Looks good to me - feel free to submit for Integration Review

            Show
            dobedobedoh Andrew Nicols added a comment - Looks good to me - feel free to submit for Integration Review
            Hide
            gerry Gerard Caulfield added a comment -

            Thanks Andrew

            Show
            gerry Gerard Caulfield added a comment - Thanks Andrew
            Hide
            gerry Gerard Caulfield added a comment -

            Please don't start integration on this just yet, I've accidentaly overwritten the branches while working on another issue.

            Show
            gerry Gerard Caulfield added a comment - Please don't start integration on this just yet, I've accidentaly overwritten the branches while working on another issue.
            Hide
            gerry Gerard Caulfield added a comment -

            ok fixed again sorry about that.

            Show
            gerry Gerard Caulfield added a comment - ok fixed again sorry about that.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Integrated thanks Gerry

            Show
            samhemelryk Sam Hemelryk added a comment - Integrated thanks Gerry
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Gerry,

            bellow is now below in all (master, 22 and 21) branches.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Gerry, bellow is now below in all (master, 22 and 21) branches.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

            Closing as fixed, heading to zzzZZZzzz, niao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12