Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Language
    • Labels:
    • Testing Instructions:
      Hide

      Run the following command on each patched branch and make sure a single line is returned:

      cat mod/resource/lang/en/resource.php | grep "\['printintroexplain'\] = 'Display resource description below content"
      

      note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "printintroexplain" string and make sure its value starts with "Display resource description below content" string.

      Show
      Run the following command on each patched branch and make sure a single line is returned: cat mod/resource/lang/en/resource.php | grep "\['printintroexplain'\] = 'Display resource description below content" note: these commands are available on *nix machines, if you are using Windows you can just search the file manually for the "printintroexplain" string and make sure its value starts with "Display resource description below content" string.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      m_MDL-29153_fix_typo_in_resource
    • Rank:
      18702

      Description

      Bellow should be changed to below before Moodlers start making loud complaining noises

      $string['printintroexplain'] = 'Display resource description bellow content?

      Feel free to backport to 2.0

      Peace - Anthony

        Activity

        Hide
        Helen Foster added a comment -

        Anthony, thanks for your report. Reassigning to moodle.com.

        Show
        Helen Foster added a comment - Anthony, thanks for your report. Reassigning to moodle.com.
        Hide
        David Mudrak added a comment -

        I'm on it!

        Show
        David Mudrak added a comment - I'm on it!
        Hide
        David Mudrak added a comment -

        Ping for myself so I don't forget to process this next week.

        Show
        David Mudrak added a comment - Ping for myself so I don't forget to process this next week.
        Hide
        David Mudrak added a comment -

        Assigning to Gerard to fix this while working on a bulk of other fixes. Thanks in advance.

        Show
        David Mudrak added a comment - Assigning to Gerard to fix this while working on a bulk of other fixes. Thanks in advance.
        Hide
        Gerard Caulfield added a comment - - edited

        Thanks David. Just wondering why you removed your patch? Was there something wrong with it?

        Show
        Gerard Caulfield added a comment - - edited Thanks David. Just wondering why you removed your patch? Was there something wrong with it?
        Hide
        Andrew Nicols added a comment -

        Looks good to me - feel free to submit for Integration Review

        Show
        Andrew Nicols added a comment - Looks good to me - feel free to submit for Integration Review
        Hide
        Gerard Caulfield added a comment -

        Thanks Andrew

        Show
        Gerard Caulfield added a comment - Thanks Andrew
        Hide
        Gerard Caulfield added a comment -

        Please don't start integration on this just yet, I've accidentaly overwritten the branches while working on another issue.

        Show
        Gerard Caulfield added a comment - Please don't start integration on this just yet, I've accidentaly overwritten the branches while working on another issue.
        Hide
        Gerard Caulfield added a comment -

        ok fixed again sorry about that.

        Show
        Gerard Caulfield added a comment - ok fixed again sorry about that.
        Hide
        Sam Hemelryk added a comment -

        Integrated thanks Gerry

        Show
        Sam Hemelryk added a comment - Integrated thanks Gerry
        Hide
        Rajesh Taneja added a comment -

        Thanks Gerry,

        bellow is now below in all (master, 22 and 21) branches.

        Show
        Rajesh Taneja added a comment - Thanks Gerry, bellow is now below in all (master, 22 and 21) branches.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

        Closing as fixed, heading to zzzZZZzzz, niao

        Show
        Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: