Moodle
  1. Moodle
  2. MDL-29158

Review repository code and improve quality and coding standard

    Details

    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      18699

      Description

      While reviewing a recent boxnet repository issue I notice several things that can be improved with the repository API including one that issue that will result in notices.
      The following are my suggestions:

      • Review all repository classes and create appropriately scoped poperty declarations. Presently there are MANY missing.
      • repository_boxnet::get_option uses $options before it is defined. Will result in a notice if that code is ever accessed.
      • Whitespace issues everywhere in the repository code!
      • bonnet::get_listing unused variables

      In summary: Review repository code, identify areas of improvement, create sub issues, complete.

      The code in generally Ok so this should be a pretty quick issue.

        Issue Links

          Activity

          Hide
          Dongsheng Cai added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.
          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          Dongsheng Cai added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: