While reviewing a recent boxnet repository issue I notice several things that can be improved with the repository API including one that issue that will result in notices.
The following are my suggestions:
- Review all repository classes and create appropriately scoped poperty declarations. Presently there are MANY missing.
- repository_boxnet::get_option uses $options before it is defined. Will result in a notice if that code is ever accessed.
- Whitespace issues everywhere in the repository code!
- bonnet::get_listing unused variables
In summary: Review repository code, identify areas of improvement, create sub issues, complete.
The code in generally Ok so this should be a pretty quick issue.