Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.3
    • Component/s: Blocks, Language
    • Labels:
    • Rank:
      18705

      Description

      The names of the following blocks in Site Administration > Plugins > Blocks > Manage Blocks are different from the add a block dropdown menu on a course page:

      Course list - Courses
      User private files - My private files
      RSS client - Remote RSS feeds

        Activity

        Hide
        Helen Foster added a comment -

        I suggest we use the names in the add a block dropdown menu and remove the lang strings 'Course list', 'User private files' and 'RSS client'.

        Show
        Helen Foster added a comment - I suggest we use the names in the add a block dropdown menu and remove the lang strings 'Course list', 'User private files' and 'RSS client'.
        Hide
        Gerard Caulfield added a comment -

        Hi Helen

        I agree with keeping the names used in the block dropdown as people will be most familiar with them. However 'Course list', 'User private files' and 'RSS client' all come from the plugin language files. 'Courses', 'My private files' and 'Remote RSS feeds' are in the minority of entries in the blocks dropdown which don't use the plugin language files to determine their names. To keep things consistent instead of just deleting the 'Course list', 'User private files' and 'RSS client' language strings, I'd like to update them to the ones currently used in the dropdown and update the dropdown to use those strings.

        The end result would be that the dropdown stays the same, but becomes populated in a consistent manner and the manage blocks page entires match up with the dropdown entries. Please let me know if you have any objections.

        Show
        Gerard Caulfield added a comment - Hi Helen I agree with keeping the names used in the block dropdown as people will be most familiar with them. However 'Course list', 'User private files' and 'RSS client' all come from the plugin language files. 'Courses', 'My private files' and 'Remote RSS feeds' are in the minority of entries in the blocks dropdown which don't use the plugin language files to determine their names. To keep things consistent instead of just deleting the 'Course list', 'User private files' and 'RSS client' language strings, I'd like to update them to the ones currently used in the dropdown and update the dropdown to use those strings. The end result would be that the dropdown stays the same, but becomes populated in a consistent manner and the manage blocks page entires match up with the dropdown entries. Please let me know if you have any objections.
        Hide
        Helen Foster added a comment -

        Hi Gerry,

        Your plan sounds good to me - thanks!

        Show
        Helen Foster added a comment - Hi Gerry, Your plan sounds good to me - thanks!
        Hide
        Gerard Caulfield added a comment -

        Hey Dan assigning you as peer reviewer (after asking you in the scrum) as I believe you understand the issues pretty well.

        Show
        Gerard Caulfield added a comment - Hey Dan assigning you as peer reviewer (after asking you in the scrum) as I believe you understand the issues pretty well.
        Hide
        Dan Poltawski added a comment -

        Gerry and I discussed if there was a away we could indicate to AMOS that some strings have been 'merged' so that if one string had been translated but not the other then it would be completed. But then realised that this wouldn't really work and in the end concluded that deleting the extra strings was the best service to translators since they have so many strings to translate already.

        Show
        Dan Poltawski added a comment - Gerry and I discussed if there was a away we could indicate to AMOS that some strings have been 'merged' so that if one string had been translated but not the other then it would be completed. But then realised that this wouldn't really work and in the end concluded that deleting the extra strings was the best service to translators since they have so many strings to translate already.
        Hide
        Dan Poltawski added a comment -

        Looks good to me - this should be master only I think.

        Show
        Dan Poltawski added a comment - Looks good to me - this should be master only I think.
        Hide
        Gerard Caulfield added a comment -

        Yeah I was also thinking master only. Thanks Dan.

        Show
        Gerard Caulfield added a comment - Yeah I was also thinking master only. Thanks Dan.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (master only)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (master only)
        Hide
        Ankit Agarwal added a comment -

        Hi,
        Looks pretty good to me.
        PAssing.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi, Looks pretty good to me. PAssing. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Well,

        I wish I said it every time
        you do the things you do.
        You always lend a helping hand,
        and I'm filled with gratitude.

        You are strong and generous
        for each and everyone one of us.
        I am eternally grateful,
        I cannot say thanks enough.

        Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: