Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Course, Filters
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Enable the multilang filter (Settings > Plugins > Filters > Manage filters)
      3. Set the multilang filter to apply to both content and headings
      4. Enter a course and turn on editing
      5. Edit a section and give it a multilang name
      6. Browse around the site and make sure the correct section name is always shown

      Areas to check:

      • Navigation
      • Course main page
      • Backup and restore

      Example multilang = <span class="multilang" lang="en">EN</span><span class="multilang" lang="NZ">NZ</span>

      Show
      Log in as an admin Enable the multilang filter (Settings > Plugins > Filters > Manage filters) Set the multilang filter to apply to both content and headings Enter a course and turn on editing Edit a section and give it a multilang name Browse around the site and make sure the correct section name is always shown Areas to check: Navigation Course main page Backup and restore Example multilang = <span class="multilang" lang="en">EN</span><span class="multilang" lang="NZ">NZ</span>
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      wip-MDL-29188-master
    • Rank:
      18525

      Description

      This task involves reviewing all of the display uses of course section names to make sure they are formatted consistently

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Up for peer-review

          Show
          Sam Hemelryk added a comment - Up for peer-review
          Hide
          Sam Hemelryk added a comment -

          Will help resolve MDL-23902 MDL-28636 and MDL-27527

          Show
          Sam Hemelryk added a comment - Will help resolve MDL-23902 MDL-28636 and MDL-27527
          Hide
          Rajesh Taneja added a comment - - edited

          Great Job Sam
          Looks Good to me.
          Just one question in backup/backup.php:

          1. Should this be the raw ($section->name) name?
          Show
          Rajesh Taneja added a comment - - edited Great Job Sam Looks Good to me. Just one question in backup/backup.php: Should this be the raw ($section->name) name?
          Hide
          Sam Hemelryk added a comment -

          Thanks for looking at this Raj, the conversion in backup/backup is fine, thanks for asking however.

          I've put this up for integration now (backporting)

          Show
          Sam Hemelryk added a comment - Thanks for looking at this Raj, the conversion in backup/backup is fine, thanks for asking however. I've put this up for integration now (backporting)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Rebased thanks Eloy

          Show
          Sam Hemelryk added a comment - Rebased thanks Eloy
          Hide
          Aparup Banerjee added a comment -

          Thanks guys, this has been integrated.

          Show
          Aparup Banerjee added a comment - Thanks guys, this has been integrated.
          Hide
          Michael de Raadt added a comment -

          The section name appeared correctly at the top of the section, but appeared as ... in the navigation and breadcrumbs. When I moused over the ... labels, the <span> tags were shown. I will attach screenshots.

          Show
          Michael de Raadt added a comment - The section name appeared correctly at the top of the section, but appeared as ... in the navigation and breadcrumbs. When I moused over the ... labels, the <span> tags were shown. I will attach screenshots.
          Hide
          Aparup Banerjee added a comment -

          changed fix version - (kept out of 20 stable)

          Show
          Aparup Banerjee added a comment - changed fix version - (kept out of 20 stable )
          Hide
          Sam Hemelryk added a comment -

          Good spotting thanks Michael, I had missed that one.
          Apu I've pushed up a couple of small fixes for both branches:

          Git: git://github.com/samhemelryk/moodle.git

          Master
          Branch: wip-MDL-29188-master-integration-fix
          Diff: https://github.com/samhemelryk/moodle/commit/113b970e62268c851b4e3b92f2d6c80c56d945ea

          MOODLE_21_STABLE
          Branch: wip-MDL-29188-m21-integration-fix
          Diff: https://github.com/samhemelryk/moodle/commit/9e312ed2690b7f07ec09670e138a7024e5e0677c

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Good spotting thanks Michael, I had missed that one. Apu I've pushed up a couple of small fixes for both branches: Git: git://github.com/samhemelryk/moodle.git Master Branch: wip- MDL-29188 -master-integration-fix Diff: https://github.com/samhemelryk/moodle/commit/113b970e62268c851b4e3b92f2d6c80c56d945ea MOODLE_21_STABLE Branch: wip- MDL-29188 -m21-integration-fix Diff: https://github.com/samhemelryk/moodle/commit/9e312ed2690b7f07ec09670e138a7024e5e0677c Cheers Sam
          Hide
          Aparup Banerjee added a comment -

          Thanks Sam, thats been integrated now.

          Show
          Aparup Banerjee added a comment - Thanks Sam, thats been integrated now.
          Hide
          Michael de Raadt added a comment -

          Test result: All good now.

          Show
          Michael de Raadt added a comment - Test result: All good now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YTC !

          (aka, yay, thanks and ciao ) Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - YTC ! (aka, yay, thanks and ciao ) Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: