[MDL-29192] It appears the arguments to email_to_user within mod/forum/lib.php::forum_cron are wrong - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.1.1, 2.2.4, 2.3.1, 2.4
Fix Version/s: 2.2.5, 2.3.2
Component/s: Forum
Labels:
- triaged

Testing Instructions:
1. Code review only, no testing required.
Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/danpoltawski/moodle.git
Pull Master Branch:
~~MDL-29192~~
Pull Master Diff URL:
https://github.com/danpoltawski/moodle/compare/MDL-29192

Description

While reviewing other things in forums lib.php I noticed that the call to email_to_user within the forum_cron method (line 921 roughly) seem to incorrect, from memory the second argument should be a user also (from user?)

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Attachments

MDL-29192.patch
1 kB
07/Apr/12 10:28 AM

Activity

People

Assignee:: Dan Poltawski

Reporter:: Sam Hemelryk

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Sam Hemelryk, Sandareka Wickramanayake

Component watchers:: Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze

Votes:: 0 Vote for this issue

Watchers:: 0 Start watching this issue

Dates

Created:: 31/Aug/11 11:03 PM

Updated:: 17/Aug/12 3:25 PM

Resolved:: 17/Aug/12 3:25 PM

Fix Release Date:: 10/Sep/12