Moodle
  1. Moodle
  2. MDL-29201

After a quiz regrade in Moodle 2.0, essay questions are left in the wrong state

    Details

    • Testing Instructions:
      Hide

      1) create a quiz with essay question
      2) attempt quiz as student or with student account, save and submit answers, close attempt
      3) manual grading report shows question needs marking
      4) run regrade all, overview no longer shows 'requires grading' on questions
      5) manual grading report says nothing to display

      Show
      1) create a quiz with essay question 2) attempt quiz as student or with student account, save and submit answers, close attempt 3) manual grading report shows question needs marking 4) run regrade all, overview no longer shows 'requires grading' on questions 5) manual grading report says nothing to display
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:
    • Rank:
      18901

      Description

      We had reports that graders were not able to see question attempts in the manual grading report.

      Investigation shows that this happens after closed essay attempts have a quiz regrade performed on them, they are left in the SUBMIT state rather than the CLOSED state as they previously were. This means they do not display in the manual grading or overview reports as requiring grading.

      To reproduce:
      1) create a quiz with essay question
      2) attempt quiz as student or with student account, save and submit answers, close attempt
      3) grader report shows question needs marking
      4) run regrade all, overview no longer shows 'requires grading' on questions
      5) manual grading report says nothing to display

      My patch for this is to set the question state to closed in the essay question grading function, and tests show this seems to result in the correct behavior.

      github link incoming shortly...

      1. moodle212_loginas.patch
        3 kB
        Gilles-Philippe Leblanc

        Activity

        Show
        Tony Levi added a comment - https://github.com/tlevi/moodle/tree/mdl29201
        Hide
        Tim Hunt added a comment -

        Oh, this is Moodle 2.0 only. No wonder it did not make any sense at first!

        Show
        Tim Hunt added a comment - Oh, this is Moodle 2.0 only. No wonder it did not make any sense at first!
        Hide
        Tim Hunt added a comment -

        Just setting this to peer-review state.

        Show
        Tim Hunt added a comment - Just setting this to peer-review state.
        Hide
        Tim Hunt added a comment -

        Looks good to me. This certainly can't cause any unpleasant side-effects, and it does seem to work. Thank you for solving this.

        Show
        Tim Hunt added a comment - Looks good to me. This certainly can't cause any unpleasant side-effects, and it does seem to work. Thank you for solving this.
        Hide
        Tim Hunt added a comment -

        I just rebased this onto the latest MOODLE_20_STABLE.

        Note to integrators. This is only relevant to the 2.0 branch.

        Show
        Tim Hunt added a comment - I just rebased this onto the latest MOODLE_20_STABLE. Note to integrators. This is only relevant to the 2.0 branch.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated into 20_STABLE, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated into 20_STABLE, many thanks!
        Hide
        Sam Hemelryk added a comment -

        Thanks guys - test passed!

        Show
        Sam Hemelryk added a comment - Thanks guys - test passed!
        Hide
        Aparup Banerjee added a comment -

        fixes have been rolled merrily up the stream! Thanks everybody!

        Show
        Aparup Banerjee added a comment - fixes have been rolled merrily up the stream! Thanks everybody!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: