Moodle
  1. Moodle
  2. MDL-29211

Formal White Theme missing lines between forum posts.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Themes
    • Labels:
      None
    • Environment:
      2.1.1+ (Build: 20110831) PHP Version 5.3.6, MySQL 5.1.57.
    • Rank:
      18912

      Description

      The Formal White theme should have lines between posts on the forum. These lines are in the Standard theme, but not in Formal White.

      Without lines, it is much harder to quickly see divisions between posts. (see attachment).

      I reported a similar need for lines between RSS feed items in MDL-24545. Maybe both problems could be solved at the same time.

        Activity

        Hide
        Mary Evans added a comment -

        Ciao Daniele, spero che vedere questo! I think Rick is right. There should be some division between forum posts. One nice way to achieve this, so that it blends in with the Formal White design, would to use a small image 1px wide by 2px high where the top pixel is dark and the bottom light, this image when repeated along the x-axis looks like a slight groove in the page, not too obvious, but a division none the less.

        What do you think?

        Show
        Mary Evans added a comment - Ciao Daniele, spero che vedere questo! I think Rick is right. There should be some division between forum posts. One nice way to achieve this, so that it blends in with the Formal White design, would to use a small image 1px wide by 2px high where the top pixel is dark and the bottom light, this image when repeated along the x-axis looks like a slight groove in the page, not too obvious, but a division none the less. What do you think?
        Hide
        Rick Jerz added a comment -

        The lines can be similar in width to what is shown between quiz attempts, or between assignments. Mary could be right, but the lines may not need to be that fancy.

        Show
        Rick Jerz added a comment - The lines can be similar in width to what is shown between quiz attempts, or between assignments. Mary could be right, but the lines may not need to be that fancy.
        Hide
        Daniele Cordella added a comment -

        Gosh!
        I am fixing few minor bugs in the health of my parents. I will become available in few tenth of hours. I am sorry. Back soon. I apologise.

        – Posted from Bugbox for iPhone

        Show
        Daniele Cordella added a comment - Gosh! I am fixing few minor bugs in the health of my parents. I will become available in few tenth of hours. I am sorry. Back soon. I apologise. – Posted from Bugbox for iPhone
        Hide
        Daniele Cordella added a comment -

        Here I have the same problem I had with MDL-29056.
        I am not able to let the comparison with MOODLE_21_STABLE to show properly!!!
        I apologise once again.

        I wish this issue can be closed without problems asap.
        Thanks Mary for your help.
        Thanks Rick for spotting this problem out.

        Show
        Daniele Cordella added a comment - Here I have the same problem I had with MDL-29056 . I am not able to let the comparison with MOODLE_21_STABLE to show properly!!! I apologise once again. I wish this issue can be closed without problems asap. Thanks Mary for your help. Thanks Rick for spotting this problem out.
        Hide
        Sam Hemelryk added a comment -

        Hi Daniele,

        In this patch there are two occurences of broken border styles within the new theme/formal_white/style/forum.css:

        .forumpost {border: 1px #CACACA double;}
        .forumpost .options div {border-top: 1px #DBDBDB dotted;}
        

        Lines 6 and 12, I've had a quick test of things and in this situation the browser is displaying a 1px solid #CACACA and 1px solid #DBDBDB and ignoring the border line style.

        Could you please fix this up or let me know what you would like it changed to and I'll fix it up.
        Other than those very minor points everything is spot on so it would be great if we can get it fixed up so that this can go in this week.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Daniele, In this patch there are two occurences of broken border styles within the new theme/formal_white/style/forum.css: .forumpost {border: 1px #CACACA double ;} .forumpost .options div {border-top: 1px #DBDBDB dotted;} Lines 6 and 12, I've had a quick test of things and in this situation the browser is displaying a 1px solid #CACACA and 1px solid #DBDBDB and ignoring the border line style. Could you please fix this up or let me know what you would like it changed to and I'll fix it up. Other than those very minor points everything is spot on so it would be great if we can get it fixed up so that this can go in this week. Cheers Sam
        Hide
        Daniele Cordella added a comment -

        Ciao Sam. I agree with you about the need to include this patch asap. It is 7:30 now bere and today is the first school day for my children both. May I meet you online in 6 hours to discuss about this issue and about MDL-29056?
        Let me know, please.

        Ciao.

        – Posted from Bugbox for iPhone

        Show
        Daniele Cordella added a comment - Ciao Sam. I agree with you about the need to include this patch asap. It is 7:30 now bere and today is the first school day for my children both. May I meet you online in 6 hours to discuss about this issue and about MDL-29056 ? Let me know, please. Ciao. – Posted from Bugbox for iPhone
        Hide
        Daniele Cordella added a comment -

        anyway:

        .forumpost {border: 1px #CACACA double;}
        .forumpost .options div {border-top: 1px #DBDBDB dotted;}
        

        both are very similar to

        border-top: 1px dotted #ccc;
        

        at line 97 of moodle20/theme/afterburner/style/afterburner_layout.css
        or to

        border-top: 1px solid #d9d9d9;
        

        at line 38 of moodle20/theme/afterburner/style/afterburner_mod.css

        I can not understand where the problem can be.

        Show
        Daniele Cordella added a comment - anyway: .forumpost {border: 1px #CACACA double ;} .forumpost .options div {border-top: 1px #DBDBDB dotted;} both are very similar to border-top: 1px dotted #ccc; at line 97 of moodle20/theme/afterburner/style/afterburner_layout.css or to border-top: 1px solid #d9d9d9; at line 38 of moodle20/theme/afterburner/style/afterburner_mod.css I can not understand where the problem can be.
        Hide
        Sam Hemelryk added a comment -

        Hi Daniele,

        I may be offline by the time you are online today sorry - I am working from NZ and am 4 hours ahead of Perth now (currently 6pm here).
        The problem with those styles is that the attributes are in the wrong order, it should be line width, line style, line colour (style and colour are round the wrong way for those two lines).
        We can of course just reverse them in which case the first border will be a double line and second will be a dotted line, however that differs to how they are being displayed at the moment (both are shown as single lines) so it comes down to what you would like to see although I'd imagine they you'd probably want them as solid lines rather than dotted or doubled.

        Although I may not be online you can always get Eloy or someone else to help you if you need it, just ask them to have a look at this issue and see what they think

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Daniele, I may be offline by the time you are online today sorry - I am working from NZ and am 4 hours ahead of Perth now (currently 6pm here). The problem with those styles is that the attributes are in the wrong order, it should be line width, line style, line colour (style and colour are round the wrong way for those two lines). We can of course just reverse them in which case the first border will be a double line and second will be a dotted line, however that differs to how they are being displayed at the moment (both are shown as single lines) so it comes down to what you would like to see although I'd imagine they you'd probably want them as solid lines rather than dotted or doubled. Although I may not be online you can always get Eloy or someone else to help you if you need it, just ask them to have a look at this issue and see what they think Cheers Sam
        Hide
        Daniele Cordella added a comment - - edited

        Great Sam!
        Thanks a lot to open my eyes.
        I did not see the problem because I was testing it in mac-firefox only.

        As far as I can understand, the following solution is the one we are looking for.

        .forumpost {border: 1px solid #CACACA;}
        .forumpost .options div {border-top: 1px dotted #DBDBDB;}
        

        If it is ok with you, please include it asap.
        Thanks for your support.

        Show
        Daniele Cordella added a comment - - edited Great Sam! Thanks a lot to open my eyes. I did not see the problem because I was testing it in mac-firefox only. As far as I can understand, the following solution is the one we are looking for. .forumpost {border: 1px solid #CACACA;} .forumpost .options div {border-top: 1px dotted #DBDBDB;} If it is ok with you, please include it asap. Thanks for your support.
        Hide
        Daniele Cordella added a comment -

        Do I need to update branches in my github?
        Do I need to submit for intergation once again? :-S

        Show
        Daniele Cordella added a comment - Do I need to update branches in my github? Do I need to submit for intergation once again? :-S
        Hide
        Daniele Cordella added a comment -

        Attached is what I tried to add to the forum.

        Show
        Daniele Cordella added a comment - Attached is what I tried to add to the forum.
        Hide
        Daniele Cordella added a comment -

        Sam,
        following your comment even:
        lines 16, 20, 22, 24, 26 of moodle20/theme/formal_white/style/calendar.css and a lot more are not correct. Are you sure about the order strictness?

        As I did for quiz.css I bind the column background colour to elements of the forum. I am going to update branches in my origin in few minutes.

        Show
        Daniele Cordella added a comment - Sam, following your comment even: lines 16, 20, 22, 24, 26 of moodle20/theme/formal_white/style/calendar.css and a lot more are not correct. Are you sure about the order strictness? As I did for quiz.css I bind the column background colour to elements of the forum. I am going to update branches in my origin in few minutes.
        Hide
        Sam Hemelryk added a comment -

        Hi Daniele,

        The purposed solution sounds great to me, if you are updating your branches I'll wait for you to do that, let me know once you have it done and I'll integrate it

        In regards to the ordering it's not essential - most modern browsers are smart enough to correct it for you however it is not a guarantee.
        In fact this made me think - after a bit of testing I had to double check myself and ended up reading http://www.w3.org/TR/CSS2/box.html#border-shorthand-properties which describes the order the properties should occur.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Hi Daniele, The purposed solution sounds great to me, if you are updating your branches I'll wait for you to do that, let me know once you have it done and I'll integrate it In regards to the ordering it's not essential - most modern browsers are smart enough to correct it for you however it is not a guarantee. In fact this made me think - after a bit of testing I had to double check myself and ended up reading http://www.w3.org/TR/CSS2/box.html#border-shorthand-properties which describes the order the properties should occur. Cheers Sam
        Hide
        Sam Hemelryk added a comment -

        Sorry Daniele, I should have added now that we have a solution if you want I can use the branches you have already and I'll fix it during integration which save you having to update it.

        I'll leave it up to let me know whether you will update you branches or whether I should fix it on integration.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Sorry Daniele, I should have added now that we have a solution if you want I can use the branches you have already and I'll fix it during integration which save you having to update it. I'll leave it up to let me know whether you will update you branches or whether I should fix it on integration. Cheers Sam
        Hide
        Daniele Cordella added a comment -

        I did all my best, Sam.
        I finished.
        I submitted once again for integration.
        Check it and, hepefully, integrate it.
        Thanks a lot for all you support.

        Show
        Daniele Cordella added a comment - I did all my best, Sam. I finished. I submitted once again for integration. Check it and, hepefully, integrate it. Thanks a lot for all you support.
        Hide
        Daniele Cordella added a comment -

        I forget to tell that I updated all branches too.

        Show
        Daniele Cordella added a comment - I forget to tell that I updated all branches too.
        Hide
        Sam Hemelryk added a comment -

        Thanks Daniele, this has been integrated now and all went smoothly

        Thank you for the persistence by the way!

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now and all went smoothly Thank you for the persistence by the way! Cheers Sam
        Hide
        Daniele Cordella added a comment -

        God bless you, Sam.
        Thanks all.

        Show
        Daniele Cordella added a comment - God bless you, Sam. Thanks all.
        Hide
        Rossiani Wijaya added a comment -

        Test passed.

        Show
        Rossiani Wijaya added a comment - Test passed.
        Hide
        Daniele Cordella added a comment -

        Thanks Wijaya!

        Show
        Daniele Cordella added a comment - Thanks Wijaya!
        Hide
        Rick Jerz added a comment -

        Do you think that your fix to adding lines between forum posts will also solve the problem with lines between RSS feed items?

        Show
        Rick Jerz added a comment - Do you think that your fix to adding lines between forum posts will also solve the problem with lines between RSS feed items?
        Hide
        Daniele Cordella added a comment -

        100% no!
        But if you open one more issue for it with a screen shot I will run to fix it as far as possible.

        Show
        Daniele Cordella added a comment - 100% no! But if you open one more issue for it with a screen shot I will run to fix it as far as possible.
        Hide
        Rick Jerz added a comment -

        Okay, I opened this issue. See MDL-29367.

        Show
        Rick Jerz added a comment - Okay, I opened this issue. See MDL-29367 .
        Hide
        Eloy Lafuente (stronk7) added a comment -

        YTC !

        (aka, yay, thanks and ciao ) Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - YTC ! (aka, yay, thanks and ciao ) Closing.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: