Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29216

Penalty & hints not available Cloze question type

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      1. Create a multi-answer question, including hints and a penalty.
      2. Re-edit the question, to verify the hints were saved properly.
      3. Preview the question in interactive mode, and verify the hints are there.
      4. Export the question as Moodle XML, re-import and verify the hints came across OK.
      5. backup and restore the course and verify the hints came across OK.

      Show
      1. Create a multi-answer question, including hints and a penalty. 2. Re-edit the question, to verify the hints were saved properly. 3. Preview the question in interactive mode, and verify the hints are there. 4. Export the question as Moodle XML, re-import and verify the hints came across OK. 5. backup and restore the course and verify the hints came across OK.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The penalty is not available on the Cloze question form.

      It is displaced lower in the form so should be added.

        Gliffy Diagrams

          Issue Links

            Activity

            ppichet Pierre Pichet created issue -
            ppichet Pierre Pichet made changes -
            Field Original Value New Value
            Summary Question Penalty is not available in all questions edit form Question Penalty is not available Cloze question type
            Description The Penalty field has been forgotten in edit_question_form.php.
            Affect all question types.
            {noformat}
                    $mform->addElement('text', 'penalty', get_string('penaltyfactor', 'question'),
                            array('size' => 3));
                    $mform->setType('penalty', PARAM_NUMBER);
                    $mform->addRule('penalty', null, 'required', null, 'client');
                    $mform->addHelpButton('penalty', 'penaltyfactor', 'question');
                    $mform->setDefault('penalty', 0.1);

            {noformat}
            to be added before
            {noformat}
                    $mform->addElement('editor', 'generalfeedback', get_string('generalfeedback', 'quiz'),
            {noformat}
             
            The penalty is not available on the Cloze question form.

            It is displaced lower in the form so should be added.


            ppichet Pierre Pichet made changes -
            Comment [ Although Tim wrote on forum that this is a bug, I do not master enough the new engine penalty schemes to be sure that this is the case i.e. the old penalty is always useful and that we should put it back in the edit form. :(

              ]
            timhunt Tim Hunt made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Pull Master Diff URL https://github.com/timhunt/moodle/compare/master...MDL-29216
            Pull Master Branch MDL-29216
            Pull 2.1 Branch MDL-29216_21
            Pull 2.1 Diff URL https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-29216_21
            timhunt Tim Hunt made changes -
            Fix Version/s 2.1.2 [ 10851 ]
            Fix Version/s 2.2 [ 10656 ]
            Labels triaged
            timhunt Tim Hunt made changes -
            Status Waiting for peer review [ 10012 ] Development in progress [ 3 ]
            timhunt Tim Hunt made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            Testing Instructions 1. Create a multi-answer question, including hints and a penalty.
            2. Re-edit the question, to verify the hints were saved properly.
            3. Preview the question in interactive mode, and verify the hints are there.
            4. Export the question as Moodle XML, re-import and verify the hints came across OK.
            5. backup and restore the course and verify the hints came across OK.
            samhemelryk Sam Hemelryk made changes -
            Currently in integration Yes
            stronk7 Eloy Lafuente (stronk7) made changes -
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator stronk7
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.2 [ 10656 ]
            Fix Version/s 2.2 [ 10656 ]
            timhunt Tim Hunt made changes -
            Summary Question Penalty is not available Cloze question type Penalty & hints not available Cloze question type
            ankit_frenz Ankit Agarwal made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester ankit_frenz
            timhunt Tim Hunt made changes -
            Link This issue caused a regression MDL-29644 [ MDL-29644 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes
            Integration date 7/Oct/11

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11