Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.2, 2.2
    • Fix Version/s: 2.1.3
    • Component/s: Gradebook, Quiz, Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Load a RTL language pack (sugest HE = Hebrew) and switch to it in order to do the testing
      2. Since the fixes are specific to the way text/images are displayed throughout Moodle it is difficult to specify instructions...so here is a list of the areas where these fixes have been made:

      • lots of right alignment of elements in quiz UI and question box
      • max grade input box in quiz grade report (from 4 to 6). This is more a usability fix not relevant to RTL specifically, but relevant to quiz and ui.
      Show
      1. Load a RTL language pack (sugest HE = Hebrew) and switch to it in order to do the testing 2. Since the fixes are specific to the way text/images are displayed throughout Moodle it is difficult to specify instructions...so here is a list of the areas where these fixes have been made: lots of right alignment of elements in quiz UI and question box max grade input box in quiz grade report (from 4 to 6). This is more a usability fix not relevant to RTL specifically, but relevant to quiz and ui.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18769

      Description

      Added RTL fixes to CSS in mod/quiz/styles.css and made a minor amendment to a value in grade/edit/tree/lib.php

      Patches submitted by Nadav,
      The "RTL & Hebrew Translation Team" (Shenkar College, Israel)

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for working on this, Nadav.

          Show
          Michael de Raadt added a comment - Thanks for working on this, Nadav.
          Hide
          Nadav Kavalerchik added a comment -

          Please review my RTL css update suggestion

          Show
          Nadav Kavalerchik added a comment - Please review my RTL css update suggestion
          Hide
          Mary Evans added a comment -

          Nadav,

          I have looked at these and they all seem OK...after Michael reviews them...what happens then?
          Can you assign yourself to this...so you take charge? Or do you want me to assign this to you?
          Cheers
          Mary

          Show
          Mary Evans added a comment - Nadav, I have looked at these and they all seem OK...after Michael reviews them...what happens then? Can you assign yourself to this...so you take charge? Or do you want me to assign this to you? Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          Thank you Mary

          I am not sure what do you mean "take charge"?
          ( I do not apply code changes directly on master )
          Don't you simply apply those changes to master?
          ( Or Michael )

          BTW,
          We (the RTL crowd) would LOVE if you can push into Moodle 2.2 all the changes in:
          This issue (MDL-29226) and MDL-27516.

          And...
          Academic year has started, today, in Israel. and although we have only a few Universities that uses Moodle 2.x there are more then 120 K12 school that uses it. so it can really help if you could push it into master. as soon as you can

          Show
          Nadav Kavalerchik added a comment - Thank you Mary I am not sure what do you mean "take charge"? ( I do not apply code changes directly on master ) Don't you simply apply those changes to master? ( Or Michael ) BTW, We (the RTL crowd) would LOVE if you can push into Moodle 2.2 all the changes in: This issue ( MDL-29226 ) and MDL-27516 . And... Academic year has started, today, in Israel. and although we have only a few Universities that uses Moodle 2.x there are more then 120 K12 school that uses it. so it can really help if you could push it into master. as soon as you can
          Hide
          Mary Evans added a comment - - edited

          @Sam
          I've just added you to MDL-29226 to ask how do we move forward with this.

          Thanks
          Mary

          Show
          Mary Evans added a comment - - edited @Sam I've just added you to MDL-29226 to ask how do we move forward with this. Thanks Mary
          Hide
          Mary Evans added a comment -

          @Nadav,

          I have set the wheels in motion. It will most probably miss this weeks roll out but we will be in a better position to get it sorted out for next week.

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Nadav, I have set the wheels in motion. It will most probably miss this weeks roll out but we will be in a better position to get it sorted out for next week. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Mary,

          Thank you very much!

          I watch all the corresponded between you and Sam.
          This is very important for me (us, the RTL folks) and i appreciate it allot.
          Again, Thank you so much (and Sam too)

          Show
          Nadav Kavalerchik added a comment - @Mary, Thank you very much! I watch all the corresponded between you and Sam. This is very important for me (us, the RTL folks) and i appreciate it allot. Again, Thank you so much (and Sam too)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
          Hide
          Mary Evans added a comment -

          @Nadav

          I hope you read Eloy's last message here and re-based these patches?

          Also can I make a suggestion, that we set up a new tracker issue for RTL language FIXES and create sub-tasks within it, so that whenever you do any work on this you can do each task as one commit, this will help when being integrated, and make things easier all round.

          I am quite happy to help you set this up if you would like me to?

          Cheers
          Mary

          Show
          Mary Evans added a comment - @Nadav I hope you read Eloy's last message here and re-based these patches? Also can I make a suggestion, that we set up a new tracker issue for RTL language FIXES and create sub-tasks within it, so that whenever you do any work on this you can do each task as one commit, this will help when being integrated, and make things easier all round. I am quite happy to help you set this up if you would like me to? Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Eloy

          I have jusy made a "git pull" and got the latest "15/11/2011 git updates" from your github.com/moodle.git account (hope it is up to date) And did not see the suggested changes from this issue, to the quiz code (for example) in my local master branch.

          I am following http://docs.moodle.org/dev/User:Sam_Hemelryk/My_Moodle_Git_workflow#Before_you_start_work_each_day instructions.

          Am i doning the right check?

          @Mary

          Great idea! please open a meta issue and i will link new issues to that one.

          Show
          Nadav Kavalerchik added a comment - @Eloy I have jusy made a "git pull" and got the latest "15/11/2011 git updates" from your github.com/moodle.git account (hope it is up to date) And did not see the suggested changes from this issue, to the quiz code (for example) in my local master branch. I am following http://docs.moodle.org/dev/User:Sam_Hemelryk/My_Moodle_Git_workflow#Before_you_start_work_each_day instructions. Am i doning the right check? @Mary Great idea! please open a meta issue and i will link new issues to that one.
          Hide
          Mary Evans added a comment -

          Hi Navdav,

          None of these patches have been added yet that's why I asked if you had re-based them...I think you were too late. Besides they are still rushing to get other stuff into Moodle 2.2...you have still time.

          As for doing the right "check" it depends if you actually pulled the new version, did you check version.php? Were you able to fast-forward? If you did FF then that's OK you can do...

          git rebase master wip-MDL-29226-master-rtl-patches

          Lets hope you don't run into any conflicts!

          In the mean time I'll set up a meta issue and see were we get with all of this.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi Navdav, None of these patches have been added yet that's why I asked if you had re-based them...I think you were too late. Besides they are still rushing to get other stuff into Moodle 2.2...you have still time. As for doing the right "check" it depends if you actually pulled the new version, did you check version.php? Were you able to fast-forward? If you did FF then that's OK you can do... git rebase master wip-MDL-29226-master-rtl-patches Lets hope you don't run into any conflicts! In the mean time I'll set up a meta issue and see were we get with all of this. Cheers Mary
          Hide
          Mary Evans added a comment -

          Nadav,

          OK...I have just added MDL-29226 as a sub-task of MDL-30337 to get the ball rolling.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Nadav, OK...I have just added MDL-29226 as a sub-task of MDL-30337 to get the ball rolling. Cheers Mary
          Hide
          Mary Evans added a comment -

          Hi Nadav,

          Moodle just got updated again so this will need to re-based again!

          Thanks
          Mary

          Show
          Mary Evans added a comment - Hi Nadav, Moodle just got updated again so this will need to re-based again! Thanks Mary
          Hide
          Nadav Kavalerchik added a comment -

          Hi Mary

          Just PULLed and it looks great!
          ( I am refering to: https://github.com/moodle/moodle/commit/1db5119839231d9ba940aab9f1b6f8b8224e16a7 )

          Thanks
          Nadav

          Show
          Nadav Kavalerchik added a comment - Hi Mary Just PULLed and it looks great! ( I am refering to: https://github.com/moodle/moodle/commit/1db5119839231d9ba940aab9f1b6f8b8224e16a7 ) Thanks Nadav
          Hide
          Mary Evans added a comment -

          EXCELLENT!!!

          Show
          Mary Evans added a comment - EXCELLENT!!!
          Hide
          Mary Evans added a comment -

          Nadav,

          I am concerned that because these are a few weeks old, and a list of 7 separate commits, it might be easier if I redo them and create 2 tasks 1 with all BASE CSS in it the other one with the QUIZ & GRADE in it, that way they might have a better chance of getting integrated.

          Usually work begins on integration on Monday from HQ which is Sunday night in the UK.

          What do you think?

          Mary

          Show
          Mary Evans added a comment - Nadav, I am concerned that because these are a few weeks old, and a list of 7 separate commits, it might be easier if I redo them and create 2 tasks 1 with all BASE CSS in it the other one with the QUIZ & GRADE in it, that way they might have a better chance of getting integrated. Usually work begins on integration on Monday from HQ which is Sunday night in the UK. What do you think? Mary
          Hide
          Nadav Kavalerchik added a comment -

          Great idea. i was not aware of it.
          Please...do the magic

          Show
          Nadav Kavalerchik added a comment - Great idea. i was not aware of it. Please...do the magic
          Hide
          Mary Evans added a comment -

          OK...leave them as they are then when I am done I'll reset the pull branches.

          Show
          Mary Evans added a comment - OK...leave them as they are then when I am done I'll reset the pull branches.
          Hide
          Mary Evans added a comment - - edited

          @Nadav

          That should make it easier now to integrate.
          Thank you for the work you have done for all these patches.

          I created a new task issue MDL-30359 for the CSS in BASE theme

          Only one question: I have added these to Moodle 2..beta (master) and MOODLE_21_STABLE (2,1,2) did you want these changes in MOODLE_20_STABLE (2.0.5) as well?

          Let me know if you do and I'll add them tomorrow.

          Cheers
          Mary

          Show
          Mary Evans added a comment - - edited @Nadav That should make it easier now to integrate. Thank you for the work you have done for all these patches. I created a new task issue MDL-30359 for the CSS in BASE theme Only one question: I have added these to Moodle 2..beta (master) and MOODLE_21_STABLE (2,1,2) did you want these changes in MOODLE_20_STABLE (2.0.5) as well? Let me know if you do and I'll add them tomorrow. Cheers Mary
          Hide
          Nadav Kavalerchik added a comment -

          @Mary
          No need to put them in Moodle 2.1 or 2.0, just in master. I suppose.
          Since master will become 2.2 and i guess we all be upgrading to that version.

          Show
          Nadav Kavalerchik added a comment - @Mary No need to put them in Moodle 2.1 or 2.0, just in master. I suppose. Since master will become 2.2 and i guess we all be upgrading to that version.
          Hide
          Mary Evans added a comment -

          Hi,
          I did not add them to M20 as the css was quite different, so I'm thankful you think it not necessary. But I thought M21 was important as this allows those who might get stuck with M21, not just yourselves, but others who use RTL.

          Cheers
          Mary

          Show
          Mary Evans added a comment - Hi, I did not add them to M20 as the css was quite different, so I'm thankful you think it not necessary. But I thought M21 was important as this allows those who might get stuck with M21, not just yourselves, but others who use RTL. Cheers Mary
          Hide
          Mary Evans added a comment -

          Nadav,
          Can you edit this page and also MDL-30359 and ADD some Testing Instructions as I am not sure what all these the changes did.

          Thanks
          Mary

          Show
          Mary Evans added a comment - Nadav, Can you edit this page and also MDL-30359 and ADD some Testing Instructions as I am not sure what all these the changes did. Thanks Mary
          Hide
          Mary Evans added a comment -

          OK...for completeness I have made MDL-30359 a sub-task of MDL-29226

          Which keeps it all together.

          Show
          Mary Evans added a comment - OK...for completeness I have made MDL-30359 a sub-task of MDL-29226 Which keeps it all together.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Hi Mary, Nadav. We (testers) need some instructions to know were to look for these fixes and what to expect. Right now it's one simple TODO, let's do it!

          Show
          Eloy Lafuente (stronk7) added a comment - Hi Mary, Nadav. We (testers) need some instructions to know were to look for these fixes and what to expect. Right now it's one simple TODO, let's do it!
          Hide
          Nadav Kavalerchik added a comment -

          Hi Eloy

          I have just joined the QA effort for testing features for the upcoming release of Moodle 2.2
          And for the first time saw QA instructions for testing patches and fixes.

          I was not prepared for this when i made those changes (patches and fixes) and was not aware that i would be asked to write instructions for testing those fixes/patches/suggestions.

          I was systematically, going through the various components of Moodle, in RTL mode, and fixing what ever looked "off" screen or miss-aligned. Then committed each tiny change with some general remark, which at that time was some what clear to me.

          The only option now, i guess, is to paste the list of committed text titles from my github account and try to follow it.
          Is that acceptable? helping? do you have any other suggestions?

          For sure, my next commits and MDL pull request will be more clear and with QA testing instruction (now, that i see how it should be writen and what is expected) sorry for the mess

          Show
          Nadav Kavalerchik added a comment - Hi Eloy I have just joined the QA effort for testing features for the upcoming release of Moodle 2.2 And for the first time saw QA instructions for testing patches and fixes. I was not prepared for this when i made those changes (patches and fixes) and was not aware that i would be asked to write instructions for testing those fixes/patches/suggestions. I was systematically, going through the various components of Moodle, in RTL mode, and fixing what ever looked "off" screen or miss-aligned. Then committed each tiny change with some general remark, which at that time was some what clear to me. The only option now, i guess, is to paste the list of committed text titles from my github account and try to follow it. Is that acceptable? helping? do you have any other suggestions? For sure, my next commits and MDL pull request will be more clear and with QA testing instruction (now, that i see how it should be writen and what is expected) sorry for the mess
          Hide
          Mary Evans added a comment -

          Nadav,

          I have added some instructions, basic though they be, but if you can expand on them that would be good.
          Thanks
          Mary

          Show
          Mary Evans added a comment - Nadav, I have added some instructions, basic though they be, but if you can expand on them that would be good. Thanks Mary
          Hide
          Aparup Banerjee added a comment -

          Thanks all, this has been integrated int 2.1.x and master(2.2)

          ps: Please test with variety of browsers and browser sizes.

          Show
          Aparup Banerjee added a comment - Thanks all, this has been integrated int 2.1.x and master(2.2) ps: Please test with variety of browsers and browser sizes.
          Hide
          Mary Evans added a comment -

          Aparup,

          I was trying to change the testing instructions last night but could not access the site...my ISP connection was very, very slow.

          I forgot that the original patches which Nadav added in the URL link were split into two separate issues. The sub-task MDL-30359 - BASE theme CSS has been fixed and the issue closed as you will see above. So the instructions for MDL-29226 are basically related to QUIZ and GRADEBOOK.

          Thanks
          Mary

          Show
          Mary Evans added a comment - Aparup, I was trying to change the testing instructions last night but could not access the site...my ISP connection was very, very slow. I forgot that the original patches which Nadav added in the URL link were split into two separate issues. The sub-task MDL-30359 - BASE theme CSS has been fixed and the issue closed as you will see above. So the instructions for MDL-29226 are basically related to QUIZ and GRADEBOOK. Thanks Mary
          Hide
          Sam Hemelryk added a comment -

          Thanks guys passing this now

          Show
          Sam Hemelryk added a comment - Thanks guys passing this now
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao
          Hide
          Nadav Kavalerchik added a comment -

          Thanks Eloy! for the update.

          Just updated my local moodle/master tree and ran a QA test of your latest upstream integration:
          https://github.com/moodle/moodle/commit/24050190e3bc962d0482d6444709f5897507112e
          (Thank you Mary for sorting my messy git commits)

          I have attached a screen capture (the second one) that shows a correct layout after the applied patches
          as it should be, when using RTL mode in Moodle. (btw, used BonFire! excellent tool)

          Show
          Nadav Kavalerchik added a comment - Thanks Eloy! for the update. Just updated my local moodle/master tree and ran a QA test of your latest upstream integration: https://github.com/moodle/moodle/commit/24050190e3bc962d0482d6444709f5897507112e (Thank you Mary for sorting my messy git commits) I have attached a screen capture (the second one) that shows a correct layout after the applied patches as it should be, when using RTL mode in Moodle. (btw, used BonFire! excellent tool)

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: