Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29229

Contact list pull-down can exceed parent column width

    Details

    • Testing Instructions:
      Hide

      1) Create a course with short name 'testestestetesttestいくつかの本当に長いタイトルタイトタイトタイトタイト'
      2) Enrol yourself onto the course
      3) View Messages (message/index.php)
      4) Verify the contact list pull-down width doesn't exceed the left hand column width.

      Show
      1) Create a course with short name 'testestestetesttestいくつかの本当に長いタイトルタイトタイトタイトタイト' 2) Enrol yourself onto the course 3) View Messages (message/index.php) 4) Verify the contact list pull-down width doesn't exceed the left hand column width.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE

      Description

      As per screenshot attached, the contact list pull-down displayed on the left hand side of the Messages page can exceed the width of the column its in if the names of courses within it exceed the length of the column.

      Is is fixed by adding a css rule to the theme to set the width to that of the parent column.

      The only side effect is that if your screen isn't wide enough, you may not be able to read the full title of course(s) in the list when its selected. While selecting (the pull-down is clicked on) the full names should be visible as expected.

      Note: pay not attention to the DB error in the screenshot, that's resolved by MDL-26607.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            aolley Adam Olley added a comment -

            Added branch/diff url for 20_stable.

            Show
            aolley Adam Olley added a comment - Added branch/diff url for 20_stable.
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for reporting that and providing a solution.

            Show
            salvetore Michael de Raadt added a comment - Thanks for reporting that and providing a solution.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks for report and patch - it looks like this was addressed in MDL-26404

            Show
            poltawski Dan Poltawski added a comment - Thanks for report and patch - it looks like this was addressed in MDL-26404
            Hide
            aolley Adam Olley added a comment -

            Hi Dan,

            Please reopen this. The core issue of the theme not being set to limit the box to the width of its container is still an issue. A simple substring on the title doesn't fix the issue (especially when there's doublewide unicode characters in play).

            Another thing to consider is that other themes that inherit the base theme may override the width of the left hand side of the messages area, but not the search box width, which would make the 30char substring ineffective even for all ascii names.

            You can test this by changing the shortname of a course that you've got in your messages pull-down list to something like:
            "testestestetesttestいくつかの本当に長いタイトルタイトタイトタイトタイト" (random ascii followed by a bunch of random doublewidth unicode characters).

            Cheers.

            Show
            aolley Adam Olley added a comment - Hi Dan, Please reopen this. The core issue of the theme not being set to limit the box to the width of its container is still an issue. A simple substring on the title doesn't fix the issue (especially when there's doublewide unicode characters in play). Another thing to consider is that other themes that inherit the base theme may override the width of the left hand side of the messages area, but not the search box width, which would make the 30char substring ineffective even for all ascii names. You can test this by changing the shortname of a course that you've got in your messages pull-down list to something like: "testestestetesttestいくつかの本当に長いタイトルタイトタイトタイトタイト" (random ascii followed by a bunch of random doublewidth unicode characters). Cheers.
            Hide
            aolley Adam Olley added a comment -

            Although likely not a problem, but there's also the consideration that institutions may want to display the full name regardless (and have altered their theme to suit) and substring-ing it to a defined length of 30 would prevent them from doing so. Just a thought that occured to me, which is easily addressed by altering the define in message/lib.php, but still.

            Show
            aolley Adam Olley added a comment - Although likely not a problem, but there's also the consideration that institutions may want to display the full name regardless (and have altered their theme to suit) and substring-ing it to a defined length of 30 would prevent them from doing so. Just a thought that occured to me, which is easily addressed by altering the define in message/lib.php, but still.
            Hide
            poltawski Dan Poltawski added a comment -

            Verified and reopenieng

            Show
            poltawski Dan Poltawski added a comment - Verified and reopenieng
            Hide
            poltawski Dan Poltawski added a comment -

            The fix looks good to solve the described problem. Submitting for integration since I have Peer Reviewed the patch - thanks Adam!

            Integrators this can be cherry picked into 21_STABLE and master.

            Show
            poltawski Dan Poltawski added a comment - The fix looks good to solve the described problem. Submitting for integration since I have Peer Reviewed the patch - thanks Adam! Integrators this can be cherry picked into 21_STABLE and master.
            Hide
            aolley Adam Olley added a comment -

            Thanks Dan, and thanks for rebasing against 2.1 since I never got around to that

            Show
            aolley Adam Olley added a comment - Thanks Dan, and thanks for rebasing against 2.1 since I never got around to that
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            rebased

            Show
            poltawski Dan Poltawski added a comment - rebased
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (21, 22 & master)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 & master)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Tested under 21_STABLE and master using a bunch of themes, both base and canvas based, looks ok in all them. Passing.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Tested under 21_STABLE and master using a bunch of themes, both base and canvas based, looks ok in all them. Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Well,

            I wish I said it every time
            you do the things you do.
            You always lend a helping hand,
            and I'm filled with gratitude.

            You are strong and generous
            for each and everyone one of us.
            I am eternally grateful,
            I cannot say thanks enough.

            Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Mar/12