Moodle
  1. Moodle
  2. MDL-29236

Filter settings for Label do not work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.2
    • Component/s: Course, Filters
    • Labels:
    • Testing Instructions:
      Hide

      Easy:
      1. Ensure that the smiley filter is enabled for your site and course.
      2. Add a label with the following text:
      Happy label
      3. Save the label.

      • A smiley appears in place of the colon and right bracket.
        4. Edit the label again. In the Settings block, click Filters.
        5. The smiley filter is shown as on (default). Select Off and save changes.
        6. Go back to the course.
      • The smiley should not appear, instead showing the colon and right bracket characters.

      (Additional test now that MDL-27001 has landed)
      7. Add a forum and type an intro with in. Turn on the 'Display description on course page' checkbox. Save and return to course.

      • Intro, including smiley (as graphic) should display below the forum name.
        8. Go back to the forum and click Filters in the setting block. Turn off the smiley filter and save changes. Go back to the course.
      • In the intro below the forum name, the smiley should now display as colon and right bracket characters.

      9. Run lib/simpletest/testfilterconfig.php unittests. All them should pass.

      Show
      Easy: 1. Ensure that the smiley filter is enabled for your site and course. 2. Add a label with the following text: Happy label 3. Save the label. A smiley appears in place of the colon and right bracket. 4. Edit the label again. In the Settings block, click Filters. 5. The smiley filter is shown as on (default). Select Off and save changes. 6. Go back to the course. The smiley should not appear, instead showing the colon and right bracket characters. (Additional test now that MDL-27001 has landed) 7. Add a forum and type an intro with in. Turn on the 'Display description on course page' checkbox. Save and return to course. Intro, including smiley (as graphic) should display below the forum name. 8. Go back to the forum and click Filters in the setting block. Turn off the smiley filter and save changes. Go back to the course. In the intro below the forum name, the smiley should now display as colon and right bracket characters. 9. Run lib/simpletest/testfilterconfig.php unittests. All them should pass.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29236-master
    • Rank:
      18778

      Description

      If you change the filter settings for a Label (for example, to disable the smiley filter) this does not have any effect. Labels always use the course filter settings.

      NOTE: I discovered this as a result of work for MDL-27001 and it will also affect the intro display from that feature. However it is an independent problem. I will be looking at it.

        Issue Links

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: