Moodle
  1. Moodle
  2. MDL-29258

Weird breadcrumb navigation text when exporting a file to a portfolio

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Portfolio
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable site-wide portfolios setting
      2. Enable file download portfolio
      3. Go to a course and create a chat
      4. Go to the chat begin a session, write something and close it
      5. Return to the chat instance and view past chat sessions
      6. Press Export all to portfolio
      7. You SHOULD NOT see any PHP warning regarding undefined 'name' offset'
      8. The breadcrumb SHOULD make sense, including the chat activity name just once
      Show
      Enable site-wide portfolios setting Enable file download portfolio Go to a course and create a chat Go to the chat begin a session, write something and close it Return to the chat instance and view past chat sessions Press Export all to portfolio You SHOULD NOT see any PHP warning regarding undefined 'name' offset' The breadcrumb SHOULD make sense, including the chat activity name just once
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29258_master

      Description

      I have submitted a private file to an assignment and then I clicked the export icon (green arrow)

      Now, it all works fine. except the weird breadcrumb navigation text.

      The filename in English is called "pdf.png".

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Thanks for reporting this.

            Feel free to help us work on this issue. If you do add a solution, please add a 'patch' label.

            Show
            Michael de Raadt added a comment - Thanks for reporting this. Feel free to help us work on this issue. If you do add a solution, please add a 'patch' label.
            Hide
            David Monllaó added a comment -

            Adding pull branches, is blocking MDLQA-5392.

            Submitting for peer review, I removed the activity name as there is already a link to the activity in the breadcrumb, not sure if there are settings that can affect this breadcrumb element.

            Show
            David Monllaó added a comment - Adding pull branches, is blocking MDLQA-5392 . Submitting for peer review, I removed the activity name as there is already a link to the activity in the breadcrumb, not sure if there are settings that can affect this breadcrumb element.
            Hide
            Andrew Davis added a comment -

            [Y] Syntax
            [NA] Output
            [Y] Whitespace
            [NA] Language
            [NA] Databases
            [Y] Testing
            [NA] Security
            [NA] Documentation
            [Y] Git
            [Y] Sanity check

            Looks good. You are go for integration.

            Show
            Andrew Davis added a comment - [Y] Syntax [NA] Output [Y] Whitespace [NA] Language [NA] Databases [Y] Testing [NA] Security [NA] Documentation [Y] Git [Y] Sanity check Looks good. You are go for integration.
            Hide
            David Monllaó added a comment -

            Thanks Andrew

            Show
            David Monllaó added a comment - Thanks Andrew
            Hide
            Dan Poltawski added a comment -

            Thanks David, integrated and tested during integration.

            Show
            Dan Poltawski added a comment - Thanks David, integrated and tested during integration.
            Hide
            Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: