Moodle
  1. Moodle
  2. MDL-29264

Completion z-index makes it bleed through messaging popup

    Details

    • Testing Instructions:
      Hide

      For this test you will need 2 users, a message sender and a message recipient. 2 browsers like Firefox and Chrome are helpful.

      Make sure that completion tracking is enabled at both the site (search the site settings) and the course level (in the course settings).

      Create and activity and set its course completion settings so that students can manually mark the activity as completed.

      Now when you go to the course page there will be a box in line with the activity that you can tick and untick.

      Go through a handful of the built in themes and check that the box is tickable and untickable (there is nothing over the top of it that prevents you from accessing it).

      Find a theme that pushes the activity completion checkbox as far as possible to the bottom right of the screen.

      Check your message recipients messaging settings and make sure they are set to popup for both online and offline. Go to the course page.

      As your message sender send the recipient a personal message.

      As the recipient refresh the course page. You will get a message popup. By scrolling and increasing the text size get the activity completion checkbox to go behind the message popup. Check that the checkbox doesnt show through.

      Show
      For this test you will need 2 users, a message sender and a message recipient. 2 browsers like Firefox and Chrome are helpful. Make sure that completion tracking is enabled at both the site (search the site settings) and the course level (in the course settings). Create and activity and set its course completion settings so that students can manually mark the activity as completed. Now when you go to the course page there will be a box in line with the activity that you can tick and untick. Go through a handful of the built in themes and check that the box is tickable and untickable (there is nothing over the top of it that prevents you from accessing it). Find a theme that pushes the activity completion checkbox as far as possible to the bottom right of the screen. Check your message recipients messaging settings and make sure they are set to popup for both online and offline. Go to the course page. As your message sender send the recipient a personal message. As the recipient refresh the course page. You will get a message popup. By scrolling and increasing the text size get the activity completion checkbox to go behind the message popup. Check that the checkbox doesnt show through.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29264_zindex
    • Rank:
      18808

      Description

      When viewing the message popup in a course and it's wide, then when there is a course completion icon behind it, the icon will bleed through. This is because the icon has a z-index of 10. I'm attaching two fixes: one incases the z-index of the popup and the other is to remove the z-index from the completion icon. I'm in favor of the removal of the z-index from the icon because it causes problems with almost any modal you try to bring up in the course, but I don't know why the z-index is there in the first place (removing doesn't seem to break, but did not do comprehensive testing). Maybe a hybrid approach would be better, as I think a z-index of 1 for the icon would be an improvement.

      1. completion_zindex.patch
        0.9 kB
        Mark Nielsen
      2. popup_zindex.patch
        0.4 kB
        Mark Nielsen

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this and providing a solution.

          Show
          Michael de Raadt added a comment - Thanks for reporting this and providing a solution.
          Hide
          Andrew Davis added a comment -

          Added testing instructions and a git branch. All I've done is remove the z-index for the activity completion elements. I'm not sure why they are there at all. Presumably there was a point at some time however there seems to be no problems caused by its removal.

          Show
          Andrew Davis added a comment - Added testing instructions and a git branch. All I've done is remove the z-index for the activity completion elements. I'm not sure why they are there at all. Presumably there was a point at some time however there seems to be no problems caused by its removal.
          Hide
          Jason Fowler added a comment -

          Looks good Andrew, just that last line of the file needs cleaning up and it's good to go

          Show
          Jason Fowler added a comment - Looks good Andrew, just that last line of the file needs cleaning up and it's good to go
          Hide
          Andrew Davis added a comment -

          After a discussion in dev chat it was decided the apparent change on the last line of the file was not significant. Creating branches and putting this up for integration.

          Show
          Andrew Davis added a comment - After a discussion in dev chat it was decided the apparent change on the last line of the file was not significant. Creating branches and putting this up for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
          Hide
          Rossiani Wijaya added a comment -

          This looks good.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks good. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -
          UPDATE tracker_issues
             SET status = 'Closed',
                comment = 'Thanks!'
          WHEN participants = 'Did a gorgeous work'
          

          This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

          Show
          Eloy Lafuente (stronk7) added a comment - UPDATE tracker_issues SET status = 'Closed', comment = 'Thanks!' WHEN participants = 'Did a gorgeous work' This landed upstream some hours ago (some - me - developer fell slept in the sofa yesterday before spamming this).

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: