Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29264

Completion z-index makes it bleed through messaging popup

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      For this test you will need 2 users, a message sender and a message recipient. 2 browsers like Firefox and Chrome are helpful.

      Make sure that completion tracking is enabled at both the site (search the site settings) and the course level (in the course settings).

      Create and activity and set its course completion settings so that students can manually mark the activity as completed.

      Now when you go to the course page there will be a box in line with the activity that you can tick and untick.

      Go through a handful of the built in themes and check that the box is tickable and untickable (there is nothing over the top of it that prevents you from accessing it).

      Find a theme that pushes the activity completion checkbox as far as possible to the bottom right of the screen.

      Check your message recipients messaging settings and make sure they are set to popup for both online and offline. Go to the course page.

      As your message sender send the recipient a personal message.

      As the recipient refresh the course page. You will get a message popup. By scrolling and increasing the text size get the activity completion checkbox to go behind the message popup. Check that the checkbox doesnt show through.

      Show
      For this test you will need 2 users, a message sender and a message recipient. 2 browsers like Firefox and Chrome are helpful. Make sure that completion tracking is enabled at both the site (search the site settings) and the course level (in the course settings). Create and activity and set its course completion settings so that students can manually mark the activity as completed. Now when you go to the course page there will be a box in line with the activity that you can tick and untick. Go through a handful of the built in themes and check that the box is tickable and untickable (there is nothing over the top of it that prevents you from accessing it). Find a theme that pushes the activity completion checkbox as far as possible to the bottom right of the screen. Check your message recipients messaging settings and make sure they are set to popup for both online and offline. Go to the course page. As your message sender send the recipient a personal message. As the recipient refresh the course page. You will get a message popup. By scrolling and increasing the text size get the activity completion checkbox to go behind the message popup. Check that the checkbox doesnt show through.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29264_zindex

      Description

      When viewing the message popup in a course and it's wide, then when there is a course completion icon behind it, the icon will bleed through. This is because the icon has a z-index of 10. I'm attaching two fixes: one incases the z-index of the popup and the other is to remove the z-index from the completion icon. I'm in favor of the removal of the z-index from the icon because it causes problems with almost any modal you try to bring up in the course, but I don't know why the z-index is there in the first place (removing doesn't seem to break, but did not do comprehensive testing). Maybe a hybrid approach would be better, as I think a z-index of 1 for the icon would be an improvement.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andyjdavis Andrew Davis
              Reporter:
              bushido Mark Nielsen
              Peer reviewer:
              Jason Fowler
              Integrator:
              Sam Hemelryk
              Tester:
              Rossiani Wijaya
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12