Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29289

Forum rating restrictions by date breaks ability to rate

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Won't Fix
    • 2.0.3
    • None
    • Forum
    • MOODLE_20_STABLE

    Description

      Choosing to restrict forum ratings by date causes an error as described in this discussion: http://moodle.org/mod/forum/discuss.php?d=175888. The problem is that the code in mod/forum/lib.php that does the date comparison tries to compare against a non-existent column. This defect was introduced with the fix for MDL-26838.

      The line that reads

      if ($info->timecreated < $info->assesstimestart || $info->timecreated > $info->assesstimefinish) {

      should be changed to

      if ($info->created < $info->assesstimestart || $info->created > $info->assesstimefinish) {

      Searching on "timecreated" will take you directly to the line with the defect.

      Attachments

        Issue Links

          Activity

            People

              andyjdavis Andrew Davis
              colin Colin Campbell
              Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              5 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: