Moodle
  1. Moodle
  2. MDL-26385 fix enrol/imsenterprise
  3. MDL-29290

CLONE - Moodle 2+ Courses created via IMS Enterprise are not getting the default course format (fix inside)

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.5, 2.1.2
    • Fix Version/s: 2.2
    • Component/s: Course
    • Labels:
      None
    • Environment:
      Moodle 2.1
      PHP 5.2; MySQL 5; Apache2
    • Database:
      Any
    • Testing Instructions:
      Hide

      Set course default setting to required parameters, eg. 12 weeks, 20MB upload.
      Use the attached sample moodle_IMS_course_create.xml file to generate three new courses.
      Go to any of these, note the settings do not reflect the system defaults.
      patch /enrol/imsenterprise/lib.php with IMSUpdate21_1.patch
      Delete the created courses.
      Rerun the IMS enterprise load, note courses are now configured with system course defaults.

      Show
      Set course default setting to required parameters, eg. 12 weeks, 20MB upload. Use the attached sample moodle_IMS_course_create.xml file to generate three new courses. Go to any of these, note the settings do not reflect the system defaults. patch /enrol/imsenterprise/lib.php with IMSUpdate21_1.patch Delete the created courses. Rerun the IMS enterprise load, note courses are now configured with system course defaults.
    • Workaround:
      Hide

      Spend your life reconfiguring every new course...

      Show
      Spend your life reconfiguring every new course...
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-29290
    • Rank:
      15977

      Description

      Courses created via IMS Enterprise are not getting the default course format, they're being created with the default of topic-format, one topic, 0 bytes upload and ignoring settings in http://moodle.myserver.ca/admin/settings.php?section=coursesettings

      By using the IMSUpdate21_1.patch the IMS Enterprise plugin will recognise the system course defaults

      1. IMSupdate21_1.patch
        2 kB
        Adam Barbary
      2. moodle_IMS_course_create.xml
        1.0 kB
        Adam Barbary
      1. Course default settings.jpg
        112 kB
      2. Course Settings after load.jpg
        82 kB

        Issue Links

          Activity

          Hide
          Adam Barbary added a comment -

          Note, this patch also addresses MDL-29273

          Show
          Adam Barbary added a comment - Note, this patch also addresses MDL-29273
          Hide
          Adam Barbary added a comment -

          Shown here are the course default settings, clearly 10 sections, and 20MB of upload.

          Show
          Adam Barbary added a comment - Shown here are the course default settings, clearly 10 sections, and 20MB of upload.
          Hide
          Adam Barbary added a comment -

          Note, defaults have been ignored, course has one topic and 0bytes max upload. Not the 10, and 20MB expected.

          Show
          Adam Barbary added a comment - Note, defaults have been ignored, course has one topic and 0bytes max upload. Not the 10, and 20MB expected.
          Hide
          Dan Marsden added a comment -

          NOTE TO INTEGRATOR:
          This contains 2 commits - one for the fix and the 2nd to fix spacing - hopefully that helps with review.

          Show
          Dan Marsden added a comment - NOTE TO INTEGRATOR: This contains 2 commits - one for the fix and the 2nd to fix spacing - hopefully that helps with review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao PS: Note this is the last message of this type that you will receive along the whole November month, because we are running continuous integration this weeks while QA tests for release of Moodle 2.2 (Dec 1st) are being performed.
          Hide
          Dan Marsden added a comment -

          rebased - thanks.

          Show
          Dan Marsden added a comment - rebased - thanks.
          Hide
          Aparup Banerjee added a comment -

          Thanks Dan, the separate coding style fixing commits did help!

          I've integrated this into master only.

          It seems that this might have been back portable to 2.1 atleast but i'm not sure if theres any specific reason for only putting up this for master.
          If this is back portable , lets do. (new issue if this has been tested by then)

          Show
          Aparup Banerjee added a comment - Thanks Dan, the separate coding style fixing commits did help! I've integrated this into master only. It seems that this might have been back portable to 2.1 atleast but i'm not sure if theres any specific reason for only putting up this for master. If this is back portable , lets do. (new issue if this has been tested by then)
          Hide
          Rossiani Wijaya added a comment -

          Hi Dan,

          Could you provide more details on how to test/upload the xml file to the course? I tried adding IMS resource in a course and upload the xml file, but keep getting invalid file type.

          Is there any other location used to upload the file creation for IMS?

          Show
          Rossiani Wijaya added a comment - Hi Dan, Could you provide more details on how to test/upload the xml file to the course? I tried adding IMS resource in a course and upload the xml file, but keep getting invalid file type. Is there any other location used to upload the file creation for IMS?
          Hide
          Rossiani Wijaya added a comment -

          Thank you for fixing and tips Dan.

          This is working great.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Thank you for fixing and tips Dan. This is working great. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, just on time for the upcoming new releases week. Thanks for it!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has landed upstream, just on time for the upcoming new releases week. Thanks for it! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: