Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.1.1, 2.6.1, Future Dev
-
Fix Version/s: 3.1
-
Component/s: Feedback
-
Testing Instructions:
-
Workaround:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_26_STABLE
-
Fixed Branches:MOODLE_31_STABLE
-
Epic Link:
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-29303-master2 -
Pull Master Diff URL:
Description
In mod/feedback/item/feedback_item_form_class.php, there is one line of code:
62 $mform->setType('label', PARAM_ALPHANUM);
|
I think it should be PARAM_TEXT since PARAM_ALPHANUM will filter out all non-alpha chars, such as Chinese and Japanese.
PS. Since label is very important to be a reference and is shown everywhere, why not set is as required field? There is always empty "()" shown before question name when the label is not set. I think it is ugly.
Reproduction steps:
- Create a feedback activity
- Edit questions
- Add one question of any type
- Fill the form and ensure input "测试" into label
- Submit the form
- Edit the question and the label is empty