Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: Database SQL/XMLDB
    • Labels:

      Description

      some devs ignore our xmldb editor....

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            This patch does patch does a minor api change (adds table param to create field sql method) - the problem was that we could not correctly report which table contains the buggy field...

            Show
            skodak Petr Skoda added a comment - This patch does patch does a minor api change (adds table param to create field sql method) - the problem was that we could not correctly report which table contains the buggy field...
            Hide
            skodak Petr Skoda added a comment -

            I have moved the max size to the xmldb_field class, please update.

            Show
            skodak Petr Skoda added a comment - I have moved the max size to the xmldb_field class, please update.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Can we also test one change_field_type() (aka, ALTER), using max+1 ?

            Also there is one mistake in the "Invalid xmldbindex..." returned by validateDefinition().

            Looks ok. Fix and will land. Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Can we also test one change_field_type() (aka, ALTER), using max+1 ? Also there is one mistake in the "Invalid xmldbindex..." returned by validateDefinition(). Looks ok. Fix and will land. Thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            skodak Petr Skoda added a comment -

            This is going to collide a bit with refactoring in MDL-29029, conflict resolution should be easy...

            Show
            skodak Petr Skoda added a comment - This is going to collide a bit with refactoring in MDL-29029 , conflict resolution should be easy...
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Same than MDL-29314. That switch / case / break syntax / space / alignment ?

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Same than MDL-29314 . That switch / case / break syntax / space / alignment ?
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated. Extra commit added to fix switch() syntax

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated. Extra commit added to fix switch() syntax
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested in Oracle and Postgres so far

            Show
            samhemelryk Sam Hemelryk added a comment - Tested in Oracle and Postgres so far
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Tested in MSSQL -> pass

            Show
            samhemelryk Sam Hemelryk added a comment - Tested in MSSQL -> pass
            Hide
            nebgor Aparup Banerjee added a comment -

            testing in SQLSRV..

            Show
            nebgor Aparup Banerjee added a comment - testing in SQLSRV..
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Ok everything tested now except for the functional DB tests on Oracle. Apu is running those presently ...

            Show
            samhemelryk Sam Hemelryk added a comment - Ok everything tested now except for the functional DB tests on Oracle. Apu is running those presently ...
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I can confirm all tests are passing here for mysql, postgresql, mssql and oracle drivers. And sqlsrv was tested by Aparup.

            So knowing that MDL-29460 has been created to investigate Aparup problems with Oracle, I think this can be safely passed. For your consideration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I can confirm all tests are passing here for mysql, postgresql, mssql and oracle drivers. And sqlsrv was tested by Aparup. So knowing that MDL-29460 has been created to investigate Aparup problems with Oracle, I think this can be safely passed. For your consideration! Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Assuming it passes under sqlsrv. After all this is master we can break it (nah, I really think this would be working ok).

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Assuming it passes under sqlsrv. After all this is master we can break it (nah, I really think this would be working ok). Ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing. Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  5/Dec/11