Moodle
  1. Moodle
  2. MDL-29323

Invalid CSS border style in the magazine theme

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Themes
    • Labels:
    • Rank:
      19027

      Description

      ./theme/magazine/style/core.css:795:    border-top: 1px #ccc solid !important;
      

      A quick test shows that the browser is displaying border-top: 1px solid #CCC which is still correct in display however it would still be nice to fix this up.

      Cheers
      Sam

        Activity

        Hide
        Mary Evans added a comment -

        Hi Sam,

        And there I was wondering why I was not getting any work to do!

        I was under the impression, all NEW (theme related) Tracker Issues would all go to me rather than Patrick.
        I am sure Martin was organising this back in April/May.

        As for this fix...Why do coders always get this order wrong! bahhhh!!!!

        Cheers

        Show
        Mary Evans added a comment - Hi Sam, And there I was wondering why I was not getting any work to do! I was under the impression, all NEW (theme related) Tracker Issues would all go to me rather than Patrick. I am sure Martin was organising this back in April/May. As for this fix...Why do coders always get this order wrong! bahhhh!!!! Cheers
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary this has been integrated now
        Hide
        Sam Hemelryk added a comment -

        BTW I will message Martin and ask him about making you component lead for theme's

        Show
        Sam Hemelryk added a comment - BTW I will message Martin and ask him about making you component lead for theme's
        Hide
        Rossiani Wijaya added a comment -

        Thanks Mary for fixing this.

        Its all good.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Thanks Mary for fixing this. Its all good. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        git repositories have been updated with your awesome changes, thanks! Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: