Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Forum
    • Labels:
    • Environment:
      2.1.1+, Build: 20110831, PHP Version 5.3.6, MySQL 5.1.57.
    • Rank:
      18865

      Description

      I am not sure if this is a bug or not, but I wanted to mention it to you. I have "debugging" turned on right now, so I am not sure if this happens to me because of debugging being on. Maybe this is "normal" behavior. Here's the problem.

      Occasionally, I get an error message "JSON parse Error" when leaving a forum. It seems to happen after I have provided ratings, and then leaving this webpage. The error message is shown the attached picture.

      This error message just shows itself briefly. I was able to capture this problem in a screen video. It's at the following URL:
      http://www.rjerz.com/v/misc/Forum-JSON_Error_Message/Forum-JSON_Error_Message.html

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          I tried to replicate this, but I couldn't.

          On my setup the rating system didn't work well with Ajax. I was receiving the following JS error...

          this.Y.io.queue is undefined
          http://localhost/moodle_testing/lib/javascript.php?file=%2Frating%2Fmodule.js&rev=267
          Line 3

          I got the same result on another of my test servers, but I wasn't able to replicate the issue on demo.moodle.net (after turning Ajax on).

          So I think there is an issue here that needs to be investigated. If you find out anything more, please add more comments.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I tried to replicate this, but I couldn't. On my setup the rating system didn't work well with Ajax. I was receiving the following JS error... this.Y.io.queue is undefined http://localhost/moodle_testing/lib/javascript.php?file=%2Frating%2Fmodule.js&rev=267 Line 3 I got the same result on another of my test servers, but I wasn't able to replicate the issue on demo.moodle.net (after turning Ajax on). So I think there is an issue here that needs to be investigated. If you find out anything more, please add more comments.
          Hide
          Rick Jerz added a comment -

          Okay. I will try to pay attention to exactly when it happens and then give you more information.

          Show
          Rick Jerz added a comment - Okay. I will try to pay attention to exactly when it happens and then give you more information.
          Hide
          Andrew Davis added a comment -

          Im bringing this into the current sprint as it is blocking MDL-25241

          Show
          Andrew Davis added a comment - Im bringing this into the current sprint as it is blocking MDL-25241
          Hide
          Andrew Davis added a comment - - edited

          Ok. This is ready for peer review. While fixing the onchange JS I noticed that the ratings JS is actually being initialized more than once so I've fixed that to.

          Ill add other branches after peer review.

          Show
          Andrew Davis added a comment - - edited Ok. This is ready for peer review. While fixing the onchange JS I noticed that the ratings JS is actually being initialized more than once so I've fixed that to. Ill add other branches after peer review.
          Hide
          Sam Hemelryk added a comment -

          Thanks Andrew, looks good to me +1 when you've got those other branches up

          Show
          Sam Hemelryk added a comment - Thanks Andrew, looks good to me +1 when you've got those other branches up
          Hide
          Andrew Davis added a comment -

          Adding 2.0 version. Note that it is only 1 commit instead of 2 as it seems that the repeated JS initialization problem was introduced in 2.1

          Show
          Andrew Davis added a comment - Adding 2.0 version. Note that it is only 1 commit instead of 2 as it seems that the repeated JS initialization problem was introduced in 2.1
          Hide
          Aparup Banerjee added a comment -

          this has been integrated and is up for testing

          Show
          Aparup Banerjee added a comment - this has been integrated and is up for testing
          Hide
          Ankit Agarwal added a comment -

          Hi,
          Working as expected.
          Test passed.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi, Working as expected. Test passed. Thanks
          Hide
          Aparup Banerjee added a comment -

          fixes have been rolled merrily up the stream! Thanks everybody!

          Show
          Aparup Banerjee added a comment - fixes have been rolled merrily up the stream! Thanks everybody!
          Hide
          Rick Jerz added a comment -

          As the author of the original post, I too want to thank everyone for your work on fixing this problem. I wasn't sure if I should post this problem (thought of it as a minor annoyance), but now I am. This really shows how everyone can help improve Moodle.

          Show
          Rick Jerz added a comment - As the author of the original post, I too want to thank everyone for your work on fixing this problem. I wasn't sure if I should post this problem (thought of it as a minor annoyance), but now I am. This really shows how everyone can help improve Moodle.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: