Moodle
  1. Moodle
  2. MDL-29341

Units buttons misaligned in numerical and calculated questions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Create a numerical qustion.
      2. Add some units, and set units to be compulsory, and Units are input using: a multiple choice selection.
      3. Preview the question and check they layout is not like in the screenshot.

      Show
      1. Create a numerical qustion. 2. Add some units, and set units to be compulsory, and Units are input using: a multiple choice selection. 3. Preview the question and check they layout is not like in the screenshot.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19047

      Description

      When units are used in a numerical or calculated question, and are displayed as a "multiple choice selection", the resulting radio buttons are poorly aligned on the screen. They are shown to the right of the answer field, with no table or CSS to align them, so in the small preview window the second radio button breaks onto a new line and appears underneath the answer field. (See image)

      Similar problems present themselves if you position the units to the left of the field.

      I have tested in Standard theme, using Safari 5.0.5, IE8 and Firefox 6.02 (all on Windows XP).

      Steps to reproduce:

      • Create a new numerical question
      • Add a name, question text, a correct answer with grade = 100%, and a wildcard answer with grade = 0
      • Set unit handling to "the unit must be given"
      • Set "units are input using" to "multiple choice selection"
      • Set "units go" to "on the right"
      • Add extra unit blanks, and enter "cm" as unit 1 and "m" as unit 2 with multiplier 0.01
      • Save changes
      • Preview this question

      The attached image shows how this appears, with the 'cm' button to the right of the field, and the 'm' button underneath the field.

      I would expect to see the options presented in an organised grouping to the right of the table.

        Activity

        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Rossiani Wijaya added a comment -

        This looks great.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This looks great. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        git repositories have been updated with your awesome changes, thanks! Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: