Moodle
  1. Moodle
  2. MDL-29360

Close window button when viewing/editing quiz question comments doesn't work

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Quiz
    • Labels:
    • Environment:
      Chrome 13 on Fedora 14 64bit
    • Testing Instructions:
      Hide

      Using a range of browsers (e.g. IE, FF, Chrome and Safari)
      1. Go to the review page of any quiz attempt.
      2. Click the 'Make comment and override grade' link by a question.
      3. Click the cancel button.
      Verify that the comment popup closes.

      Show
      Using a range of browsers (e.g. IE, FF, Chrome and Safari) 1. Go to the review page of any quiz attempt. 2. Click the 'Make comment and override grade' link by a question. 3. Click the cancel button. Verify that the comment popup closes.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When reviewing a quiz attempt, clicking "Make comment or override grade" pops open a new window with the question. You have two options, submit and cancel. Clicking on cancel doesn't do anything.

      This is as the onclick is set to "close_window()".

      This appears to be an issue when using Chrome as it throws a javascript error (it can't access the e element as its never passed to close_window). Looks like it might affect IE as well, but not FF.

      Fix for this would be to change the onclick to say, "close_window(this);"

        Gliffy Diagrams

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Tim this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Tim this has been integrated now
          Hide
          Andrew Davis added a comment -

          Ive tested this in FF and Chrome. Im having trouble with VMware so I am currently unable to test this in IE and Safari

          Show
          Andrew Davis added a comment - Ive tested this in FF and Chrome. Im having trouble with VMware so I am currently unable to test this in IE and Safari
          Hide
          Rossiani Wijaya added a comment -

          This works great in IE, FF, Chrome, and safari.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This works great in IE, FF, Chrome, and safari. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: