Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29360

Close window button when viewing/editing quiz question comments doesn't work

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.4, 2.1.1
    • 2.0.5, 2.1.2
    • Quiz
    • Chrome 13 on Fedora 14 64bit
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • Hide

      Using a range of browsers (e.g. IE, FF, Chrome and Safari)
      1. Go to the review page of any quiz attempt.
      2. Click the 'Make comment and override grade' link by a question.
      3. Click the cancel button.
      Verify that the comment popup closes.

      Show
      Using a range of browsers (e.g. IE, FF, Chrome and Safari) 1. Go to the review page of any quiz attempt. 2. Click the 'Make comment and override grade' link by a question. 3. Click the cancel button. Verify that the comment popup closes.

    Description

      When reviewing a quiz attempt, clicking "Make comment or override grade" pops open a new window with the question. You have two options, submit and cancel. Clicking on cancel doesn't do anything.

      This is as the onclick is set to "close_window()".

      This appears to be an issue when using Chrome as it throws a javascript error (it can't access the e element as its never passed to close_window). Looks like it might affect IE as well, but not FF.

      Fix for this would be to change the onclick to say, "close_window(this);"

      Attachments

        Activity

          People

            timhunt Tim Hunt
            aolley Adam Olley
            Sam Hemelryk Sam Hemelryk
            Rossiani Wijaya Rossiani Wijaya
            Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              10/Oct/11