Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29360

Close window button when viewing/editing quiz question comments doesn't work

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Quiz
    • Labels:
    • Environment:
      Chrome 13 on Fedora 14 64bit
    • Testing Instructions:
      Hide

      Using a range of browsers (e.g. IE, FF, Chrome and Safari)
      1. Go to the review page of any quiz attempt.
      2. Click the 'Make comment and override grade' link by a question.
      3. Click the cancel button.
      Verify that the comment popup closes.

      Show
      Using a range of browsers (e.g. IE, FF, Chrome and Safari) 1. Go to the review page of any quiz attempt. 2. Click the 'Make comment and override grade' link by a question. 3. Click the cancel button. Verify that the comment popup closes.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When reviewing a quiz attempt, clicking "Make comment or override grade" pops open a new window with the question. You have two options, submit and cancel. Clicking on cancel doesn't do anything.

      This is as the onclick is set to "close_window()".

      This appears to be an issue when using Chrome as it throws a javascript error (it can't access the e element as its never passed to close_window). Looks like it might affect IE as well, but not FF.

      Fix for this would be to change the onclick to say, "close_window(this);"

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            aolley Adam Olley
            Integrator:
            Sam Hemelryk
            Tester:
            Rossiani Wijaya
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Oct/11