Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29361

Backport TinyMCE to 21_STABLE (3.4.5)

    Details

    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_21_STABLE

      Description

      This is a followup for MDL-28455 and MDL-29081

      Once tested and working ok, backport TinyMCE (3.4.5) and spell-checker from master to 21_STABLE.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Adding Petr and David as watchers...

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Adding Petr and David as watchers...
              Hide
              skodak Petr Skoda added a comment -

              thanks, I am going to rebase once the weekly lands

              Show
              skodak Petr Skoda added a comment - thanks, I am going to rebase once the weekly lands
              Hide
              skodak Petr Skoda added a comment -

              the MDL-29081 should be included too, I am delaying this till next week, we need to get more testing...

              Show
              skodak Petr Skoda added a comment - the MDL-29081 should be included too, I am delaying this till next week, we need to get more testing...
              Hide
              korpelainen Mauno Korpelainen added a comment -

              Any open issues left ???

              Show
              korpelainen Mauno Korpelainen added a comment - Any open issues left ???
              Hide
              skodak Petr Skoda added a comment -

              no issue that I would know of, my +1 to backport it

              Show
              skodak Petr Skoda added a comment - no issue that I would know of, my +1 to backport it
              Hide
              smithrn Ryan Smith added a comment -

              Just a quick note, TinyMCE 3.4.6 is now out.

              http://www.tinymce.com/develop/changelog/index.php?type=tinymce

              Several IE fixes again:
              Fixed accessibility bugs in WebKit and IE8 where toolbar items were not being read.
              Fixed bug where anchors wasn't updated properly if you edited them using IE 8.
              Fixed bug where the media plugin wouldn't work on IE9 when not using the inlinepopups plugin.
              Fixed bug where the style attribute of layers wasn't properly updated on IE and Gecko.
              Fixed bug where IE 6/7 would produce JS errors when serializing contents containing layers.

              Show
              smithrn Ryan Smith added a comment - Just a quick note, TinyMCE 3.4.6 is now out. http://www.tinymce.com/develop/changelog/index.php?type=tinymce Several IE fixes again: Fixed accessibility bugs in WebKit and IE8 where toolbar items were not being read. Fixed bug where anchors wasn't updated properly if you edited them using IE 8. Fixed bug where the media plugin wouldn't work on IE9 when not using the inlinepopups plugin. Fixed bug where the style attribute of layers wasn't properly updated on IE and Gecko. Fixed bug where IE 6/7 would produce JS errors when serializing contents containing layers.
              Hide
              dougiamas Martin Dougiamas added a comment -

              +1 to backport new TinyMCE to fix bugs

              Show
              dougiamas Martin Dougiamas added a comment - +1 to backport new TinyMCE to fix bugs
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This is warning to remind that we are already using 3.4.6 in master (MDL-29785), so surely backporting should be done from that if everything works ok after some days. It includes IE and FF7 fixes + support for iOS.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This is warning to remind that we are already using 3.4.6 in master ( MDL-29785 ), so surely backporting should be done from that if everything works ok after some days. It includes IE and FF7 fixes + support for iOS.
              Hide
              smithrn Ryan Smith added a comment -

              Just a quick note, TinyMCE 3.4.7 is now out.

              http://www.tinymce.com/develop/changelog/index.php?type=tinymce

              Many more IE fixes.

              Will this be updated in the stable branch of Moodle 2.1 anytime soon? It sure would be nice to bring some of these fixes to our IE users.

              Show
              smithrn Ryan Smith added a comment - Just a quick note, TinyMCE 3.4.7 is now out. http://www.tinymce.com/develop/changelog/index.php?type=tinymce Many more IE fixes. Will this be updated in the stable branch of Moodle 2.1 anytime soon? It sure would be nice to bring some of these fixes to our IE users.
              Hide
              syxton Matthew Davidson added a comment -

              Is it just me or does anyone else think that 2 months is plenty of time to update an integral piece of integrated software and that, since it is used throughout Moodle, it should be kept up to date at a pretty high priority.

              Show
              syxton Matthew Davidson added a comment - Is it just me or does anyone else think that 2 months is plenty of time to update an integral piece of integrated software and that, since it is used throughout Moodle, it should be kept up to date at a pretty high priority.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Surely it's just you, dear, pfff

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Surely it's just you, dear, pfff
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              (thanks for bringing attention over this, btw)

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - (thanks for bringing attention over this, btw)
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              (note we are already using 3.4.6 on master, for the records)

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - (note we are already using 3.4.6 on master, for the records)
              Hide
              skodak Petr Skoda added a comment -

              Hello, we are not going to backport any TinyMCE I am afraid, thanks for the report and sorry for the bad news. Ciao.

              Show
              skodak Petr Skoda added a comment - Hello, we are not going to backport any TinyMCE I am afraid, thanks for the report and sorry for the bad news. Ciao.

                People

                • Votes:
                  4 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: