Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29276 META- Web service improvements for 2.2
  3. MDL-29374

Exceptions returned by moodle_user_create_users are not explicit

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: 2.1.1
    • Fix Version/s: STABLE backlog
    • Component/s: Web Services
    • Labels:
      None
    • Testing Instructions:
      Hide

      Use the built-in web service client and try to create a user with an existing username. The error message should be explicit.

      Show
      Use the built-in web service client and try to create a user with an existing username. The error message should be explicit.
    • Affected Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
      git@github.com:mouneyrac/moodle.git
    • Pull Master Branch:

      Description

      use moodle_exception instead of the current not explicit invalid_param_exception

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              jerome Jérôme Mouneyrac added a comment -

              I backed ported the improvement in 2.0 and 2.1

              Show
              jerome Jérôme Mouneyrac added a comment - I backed ported the improvement in 2.0 and 2.1
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              skodak Petr Skoda added a comment -

              Who is going to translate all these unlikely error messages? Web interface does not (and can not) return verbose error messages either, that is why we have the debug mode. The external lib should imo use the same logic! The iphone client and friends should display the returned debug info when you configure it to do that...

              my -1

              Show
              skodak Petr Skoda added a comment - Who is going to translate all these unlikely error messages? Web interface does not (and can not) return verbose error messages either, that is why we have the debug mode. The external lib should imo use the same logic! The iphone client and friends should display the returned debug info when you configure it to do that... my -1
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Reopening as discussed thanks Jerome. I agree with Petr here again sorry, keeping these messages generic and providing debugging information should be toggled upon configuration.

              Show
              samhemelryk Sam Hemelryk added a comment - Reopening as discussed thanks Jerome. I agree with Petr here again sorry, keeping these messages generic and providing debugging information should be toggled upon configuration.
              Hide
              jerome Jérôme Mouneyrac added a comment -

              No need to be fixed as commented by Petr and Sam. Thanks for your reviews

              Show
              jerome Jérôme Mouneyrac added a comment - No need to be fixed as commented by Petr and Sam. Thanks for your reviews
              Hide
              jerome Jérôme Mouneyrac added a comment - - edited

              Note that when MDL-29435 is fixed, then the error message will be explicit in SOAP and XMLRPC. They already are explicit with the REST servers.

              Show
              jerome Jérôme Mouneyrac added a comment - - edited Note that when MDL-29435 is fixed, then the error message will be explicit in SOAP and XMLRPC. They already are explicit with the REST servers.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: