This fix works for us. Mahmoud's work, but I transferred it from OU moodle.

Although I have already submitted it for integration, it would be great if you could take a look Andrew.

Looks good. The only query I have is with the removal of this

} else if (array_key_exists('user', $reports)) {

   $last = 'user';

which has been replaced by this

} else if (array_key_exists($CFG->grade_profilereport, $reports)) {

   $last = $CFG->grade_profilereport;

If $CFG->grade_profilereport is not set at all will it still default to the user report? It looks like it will fall through to $last = key(reset($reports)); and Im not sure what that will return. Maybe the if clause that explicitly defaults to the user report wants to be retained but should appear after the $CFG->grade_profilereport clause.

Hi guys,

I'm failing this because there is a coding error, reset returns the first element of an array so calling key(reset($reports)) is certainly going to lead to notices because you're calling key what ever the first element is.

In regards to the default I think you are right as well Andrew, I'd think ideally the default should remain the user report although hardcoding that is horrid so perhaps only using user is if it is available. What are your thoughts on that Tim?

Cheers
Sam

$CFG->grade_profilereport is set to its default value ('user') on install. On the admin screens, this value is set using a select menu of available reports, so there is no way it can be blank. So, no point in keeping the explicit 'user' clause in the if.

I will fix the coding error. Sorry.

All three branches amended. Note that the key(reset($reports)); problem has been there since forever. We did not change it in our patch. Still, fixed now.

(oops, apologizes, I got this by mistake, sending back to Sam)

Thanks for clearing that all up Tim, this has been integrated now

Cheers
Sam

Works Great
Thanks for fixing this Tim

FYI:
Tested by adding a dummy grade report, replicating user report.

And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing.

Ciao