Moodle
  1. Moodle
  2. MDL-37417 Question editing forms improvements
  3. MDL-29394

Use a hidden field instead of a selector when there is only one html editor format option

    Details

    • Testing Instructions:
      Hide

      Find a form with an html editor with only 1 option in the format options select list below the editor itself. quiz question type forms are a good place or the description field of course activity edit forms with html format selected. With fix applied the select list should disappear. View the source for the format option field as a hidden form field.

      Show
      Find a form with an html editor with only 1 option in the format options select list below the editor itself. quiz question type forms are a good place or the description field of course activity edit forms with html format selected. With fix applied the select list should disappear. View the source for the format option field as a hidden form field.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
      git@github.com:colchambers/moodle.git
    • Pull Master Branch:
    • Rank:
      19100

      Description

      Moodle quiz question type forms can get quite lengthy. It would help to hide fields that aren't essential. There is often only one format option available in question type html editor fields. So the select field is irrelevant. Use a hidden input field instead,

      This is a core change which will affect all html editor instances. This issue also occurs in course activity edit forms with the introduction field. Space will be saved there too.

      This option is common in in the description field of the course activity settings forms and in quiz question types such as Drag and drop and matching.

      OU bug #947

        Activity

        Hide
        Tim Hunt added a comment -

        I think this is a small but significant usability improvement. I am pretty sure I discussed this with someone (Petr?) in developer chat some months ago, and it was agreed that this was a good idea.

        We should have a patch for you next week.

        Show
        Tim Hunt added a comment - I think this is a small but significant usability improvement. I am pretty sure I discussed this with someone (Petr?) in developer chat some months ago, and it was agreed that this was a good idea. We should have a patch for you next week.
        Hide
        Michael de Raadt added a comment -

        Thanks for proposing this. That would be a simple improvement.

        It took me a bit to figure out which option you were referring to, so I'll attach a screenshot to add a thousand words.

        Show
        Michael de Raadt added a comment - Thanks for proposing this. That would be a simple improvement. It took me a bit to figure out which option you were referring to, so I'll attach a screenshot to add a thousand words.
        Hide
        Colin Chambers added a comment -

        Thanks Michael. That's very helpful.

        Show
        Colin Chambers added a comment - Thanks Michael. That's very helpful.
        Hide
        Colin Chambers added a comment -

        developed the fix. Added to master and 2.1 branches

        Show
        Colin Chambers added a comment - developed the fix. Added to master and 2.1 branches
        Hide
        Colin Chambers added a comment -

        Added the git branch and url details for master and 2.1 branch. Fix is committed. Ready for review.

        Show
        Colin Chambers added a comment - Added the git branch and url details for master and 2.1 branch. Fix is committed. Ready for review.
        Hide
        Tim Hunt added a comment -

        Looks good to me.

        Show
        Tim Hunt added a comment - Looks good to me.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated thanks!

        Note I've picked your original commit and amended it to clean some incorrect whitespace and the commit message (I've left the #947 coz I suppose it will have some meaning in your env).

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated thanks! Note I've picked your original commit and amended it to clean some incorrect whitespace and the commit message (I've left the #947 coz I suppose it will have some meaning in your env). Ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, tested and passed

        Show
        Sam Hemelryk added a comment - Thanks guys, tested and passed
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: