Moodle
  1. Moodle
  2. MDL-29399

Boxxie theme TinyMCE editor cut off on right in online text activity

    Details

    • Testing Instructions:
      Hide
      1. Select Boxxie theme in Theme selector
      2. Choose a course that has a Text Assignment activity.
      3. Make sure there are blocks on both sides of the page.
      4. As a student open the text assignment to edit it.
      5. Test to see that the TinyMCE editor displays fully in the area provided.
      Show
      Select Boxxie theme in Theme selector Choose a course that has a Text Assignment activity. Make sure there are blocks on both sides of the page. As a student open the text assignment to edit it. Test to see that the TinyMCE editor displays fully in the area provided.
    • Workaround:
      Hide

      Instruct all students to compose their text offline in a word-processor, and then copy and paste the text into the truncated editor box.

      Show
      Instruct all students to compose their text offline in a word-processor, and then copy and paste the text into the truncated editor box.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Rank:
      19326

      Description

      The tiny MCE editor area is severely cut off on the right side in online text activities in multiple browsers and screen sizes. See attached image.

      Steps to create problem:
      1- Add a online text activity
      2- enter the activity and click add submission button
      3- note the editor area at bottom of window is cut off.

      Theme is Boxxie

        Issue Links

          Activity

          Hide
          Gerry added a comment -

          Also of note is the very large unused space between the sidebars and the content area.

          Show
          Gerry added a comment - Also of note is the very large unused space between the sidebars and the content area.
          Hide
          Jim Peterson added a comment -

          When we had this at our school the solution in the near term was to reduce the zoom on the browser until you could see the lower right hand corner of the editor and drag it to fit the available space.

          Show
          Jim Peterson added a comment - When we had this at our school the solution in the near term was to reduce the zoom on the browser until you could see the lower right hand corner of the editor and drag it to fit the available space.
          Hide
          Michael de Raadt added a comment -

          This appears to be an issue with the Boxie theme. I wasn't able to reproduce this with any other theme I tried.

          Show
          Michael de Raadt added a comment - This appears to be an issue with the Boxie theme. I wasn't able to reproduce this with any other theme I tried.
          Hide
          Michael de Raadt added a comment -

          I've attached a screenshot with the affected div inspected. The style #page-mod-assignment-view fieldset .fitem has a width value of 50%. Removing this style attribute resolves the problem.

          Show
          Michael de Raadt added a comment - I've attached a screenshot with the affected div inspected. The style #page-mod-assignment-view fieldset .fitem has a width value of 50%. Removing this style attribute resolves the problem.
          Hide
          Gerry added a comment -

          This worked. I also changed:
          #page-mod-assignment-view .generalbox {
          width: 100%;

          To get smaller margins between side bars and content.
          Hope these changes are in next release.
          Thank you.

          Show
          Gerry added a comment - This worked. I also changed: #page-mod-assignment-view .generalbox { width: 100%; To get smaller margins between side bars and content. Hope these changes are in next release. Thank you.
          Hide
          Glenn Pillsbury added a comment -

          Those fixes seem to work as long as editing is turned off. If editing is turned on, the editor in forums is still cut off by the right page column.

          Show
          Glenn Pillsbury added a comment - Those fixes seem to work as long as editing is turned off. If editing is turned on, the editor in forums is still cut off by the right page column.
          Hide
          Mary Evans added a comment -

          Thanks for that bit of info...I should be able to fix that now.

          Show
          Mary Evans added a comment - Thanks for that bit of info...I should be able to fix that now.
          Hide
          Mary Evans added a comment -

          I thought I had fixed this ages ago!
          Apparently not...because the problem persists if you have blocks on both sides.

          All fixed now though.

          Show
          Mary Evans added a comment - I thought I had fixed this ages ago! Apparently not...because the problem persists if you have blocks on both sides. All fixed now though.
          Hide
          Sam Hemelryk added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Sam Hemelryk added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mary Evans added a comment -

          Rebased...

          Show
          Mary Evans added a comment - Rebased...
          Hide
          Sam Hemelryk added a comment -

          Hi Mary,

          I was just having a look at this now, I'm sending it back because it appears the original problem hasn't been fixed in MOODLE_21_STABLE (I havn't checked MOODLE_22_STABLE).

          I noticed in the attached screenshots that there was a width:50% begin shown in the developer tools.
          I loaded up master and sure enough it had been fixed there, so I loaded up 21 and found the 50%.
          Because of that I don't think we need to make the purposed changes here, it looks like all you'll need to do is fix the 50% width on `#page-mod-assignment-view fieldset .fitem` in MOODLE_21_STABLE.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary, I was just having a look at this now, I'm sending it back because it appears the original problem hasn't been fixed in MOODLE_21_STABLE (I havn't checked MOODLE_22_STABLE). I noticed in the attached screenshots that there was a width:50% begin shown in the developer tools. I loaded up master and sure enough it had been fixed there, so I loaded up 21 and found the 50%. Because of that I don't think we need to make the purposed changes here, it looks like all you'll need to do is fix the 50% width on ` #page-mod-assignment-view fieldset .fitem ` in MOODLE_21_STABLE. Cheers Sam
          Hide
          Mary Evans added a comment -

          Will do...thanks

          Show
          Mary Evans added a comment - Will do...thanks
          Hide
          Mary Evans added a comment -

          Lot of white space cleaned up automatically on save.
          I applied the same fix as previous commit whenever that was!

          Show
          Mary Evans added a comment - Lot of white space cleaned up automatically on save. I applied the same fix as previous commit whenever that was!
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Mary - has been integrated now
          Hide
          Andrew Davis added a comment - - edited

          Editor displayed properly in both the old and new assignment modules. Passing.

          Show
          Andrew Davis added a comment - - edited Editor displayed properly in both the old and new assignment modules. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          U P S T R E A M I Z E D !

          Many thanks for the hard work, closing this as fixed.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: