Moodle
  1. Moodle
  2. MDL-29400

Single file assignment displays 'File uploaded successfully' when no file uploaded

    Details

    • Testing Instructions:
      Hide
      1. The following test need to be run on 21, 22 and master
      2. create an assignments of type "Upload a single file" and "Advanced uploading of files"
      3. Go to upload a file on both.
      4. "Save changes" without choosing a file - the form should prevent you from saving changes
      5. Under "Settings/Assignment administration" you should NOT be able to see a message telling you that the assignment was submitted on a certain date, as can be seen in the attached screenshot [2012-03-07 12-08-31_Upload single file assignment - Mozilla Firefox.png].
      6. On both assignments go to upload a file again and this time actually upload a file. In the Advanced uploading of files, don't click "Send for marking" yet.
      7. Again under "Settings/Assignment administration" you should be able to see a message telling you that the assignment was submitted on a certain date, as can be seen in the attached screenshot. In the Advanced uploading of files assignment, the submission should be marked as a draft.
      8. Now, as a student, submit the Advanced upload of files
      9. Under "Settings/Assignment administration" you should see that the Advanced upload of files assignment submission is now complete.
      Show
      The following test need to be run on 21, 22 and master create an assignments of type "Upload a single file" and "Advanced uploading of files" Go to upload a file on both. "Save changes" without choosing a file - the form should prevent you from saving changes Under "Settings/Assignment administration" you should NOT be able to see a message telling you that the assignment was submitted on a certain date, as can be seen in the attached screenshot [2012-03-07 12-08-31_Upload single file assignment - Mozilla Firefox.png] . On both assignments go to upload a file again and this time actually upload a file. In the Advanced uploading of files, don't click "Send for marking" yet. Again under "Settings/Assignment administration" you should be able to see a message telling you that the assignment was submitted on a certain date, as can be seen in the attached screenshot. In the Advanced uploading of files assignment, the submission should be marked as a draft. Now, as a student, submit the Advanced upload of files Under "Settings/Assignment administration" you should see that the Advanced upload of files assignment submission is now complete.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Rank:
      18920

      Description

      Assignment file upload without choosing a file?
      Shouldn't an error like "Error: No file selected" or something come up?
      Now you see a submitted date and think you are done with this.

      /moodle/mod/assignment/type/upload/upload.php

      1. MDL-29400.patch
        4 kB
        Michael de Raadt
      1. 2012-03-07 12-08-31_Upload single file assignment - Mozilla Firefox.png
        89 kB
      2. Auswahl_047.png
        47 kB
      3. screenshot3.png
        101 kB
      4. student_view.jpg
        40 kB
      5. teacher_view.jpg
        46 kB

        Issue Links

          Activity

            People

            • Votes:
              13 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: