Moodle
  1. Moodle
  2. MDL-29402

Discussion topics not mailed out in Q and A forums unless the student has posted

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9.17, 2.2.2, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Forum
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. Create a Q and A type forum.
      2. Add teachers and students. Force subscriptions.
      3. Post a question as a teacher.

      The student should get an email notification of the question, but should not get other answers until participating.

      Show
      1. Create a Q and A type forum. 2. Add teachers and students. Force subscriptions. 3. Post a question as a teacher. The student should get an email notification of the question, but should not get other answers until participating.
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29402-master
    • Rank:
      19035

      Description

      MDL-9376 prevents a student from receiving forum emails from a Q and A type forum unless they have posted to the forum. This prevents students from getting other students' responses. Unfortunately, it also prevents a student from receiving the initial question, which is unexpected (from the point of view of the instructor). See https://github.com/mackensen/moodle/compare/MOODLE_19_STABLE...MDL-29402 for potential untested fix.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          This still seems to be a problem in current supported versions.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. This still seems to be a problem in current supported versions.
          Hide
          Charles Fulton added a comment -

          I've tested this patch against 1.9.14 and it works as expected.

          Show
          Charles Fulton added a comment - I've tested this patch against 1.9.14 and it works as expected.
          Hide
          Rajesh Taneja added a comment -

          I agree, first post should be mailed to user.

          Patch looks great Charles.
          Can you please provide patch for master branch as well, and align if statement.
          Please refer Moodle coding style for more info.

          Show
          Rajesh Taneja added a comment - I agree, first post should be mailed to user. Patch looks great Charles. Can you please provide patch for master branch as well, and align if statement. Please refer Moodle coding style for more info.
          Hide
          Charles Fulton added a comment -

          Changes made and pushed; also rebased off current weeklies.

          Show
          Charles Fulton added a comment - Changes made and pushed; also rebased off current weeklies.
          Hide
          Rajesh Taneja added a comment -

          Thanks Charles,
          Pushing it up for integartion review.

          Show
          Rajesh Taneja added a comment - Thanks Charles, Pushing it up for integartion review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Charles for providing the fix.
          This has been integrated into Moodle 2.1+, 2.2+ and master.
          It wasn't integrated into the 1.9+ branch sorry as that is only receiving security fixes (or those deemed uber critical).

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Charles for providing the fix. This has been integrated into Moodle 2.1+, 2.2+ and master. It wasn't integrated into the 1.9+ branch sorry as that is only receiving security fixes (or those deemed uber critical). Cheers Sam
          Hide
          Gerard Caulfield added a comment -

          Doesn't appear to be sending emails consistently. I just added a question in 2.1, ran the cron and saw no email being sent to the student that I had set up, however that is not to say the email was not sent before running the cron, such as at the time the question was added.

          However I can not currently get a proper testing environment for this issue as email is not working. The port is blocked for sending emails and our SMTP provider does not forward our requests. I've also tried using my Gmail as the SMTP account using the directions given here: http://docs.moodle.org/22/en/Email_setup_gmail. However this also did not work.

          I am removing myself as the tester so that it can be tested by somebody else who has an environment that can send emails as I can not properly test this with mine.

          I have asked in dev chat if anybody external to the office is able to test this.

          Show
          Gerard Caulfield added a comment - Doesn't appear to be sending emails consistently. I just added a question in 2.1, ran the cron and saw no email being sent to the student that I had set up, however that is not to say the email was not sent before running the cron, such as at the time the question was added. However I can not currently get a proper testing environment for this issue as email is not working. The port is blocked for sending emails and our SMTP provider does not forward our requests. I've also tried using my Gmail as the SMTP account using the directions given here: http://docs.moodle.org/22/en/Email_setup_gmail . However this also did not work. I am removing myself as the tester so that it can be tested by somebody else who has an environment that can send emails as I can not properly test this with mine. I have asked in dev chat if anybody external to the office is able to test this.
          Hide
          Andrew Nicols added a comment -

          I've tested against the following branches on git://git.moodle.org/integration.git :

          • master
          • MOODLE_22_STABLE
          • MOODLE_21_STABLE

          All behave as expected.

          I'm using a local exim delivery whereby all mail from moodle is delivered into a local mailbox.

          Show
          Andrew Nicols added a comment - I've tested against the following branches on git://git.moodle.org/integration.git : master MOODLE_22_STABLE MOODLE_21_STABLE All behave as expected. I'm using a local exim delivery whereby all mail from moodle is delivered into a local mailbox.
          Hide
          Gerard Caulfield added a comment -

          Thanks for that Andrew and I'll try what you have suggested.

          Show
          Gerard Caulfield added a comment - Thanks for that Andrew and I'll try what you have suggested.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some changes to Moodle should be milestones in the project by themselves.

          This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some changes to Moodle should be milestones in the project by themselves. This is not the case and your fix is not so important, but your collaboration is highly appreciated, thanks! Closing as fixed, ciao

            People

            • Votes:
              7 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: