Moodle
  1. Moodle
  2. MDL-29403

ROLE EDIT default value not showing in theme FORMAL WHITE

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Themes
    • Labels:
    • Environment:
      RHEL 5, Firefox 6
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Select theme FORMAL WHITE
      Go to Home->Site administration->Users->Permissions->Define roles
      Edit a role
      Push the show advanced button.

      Defaults should now be highlighted

      Show
      Select theme FORMAL WHITE Go to Home->Site administration->Users->Permissions->Define roles Edit a role Push the show advanced button. Defaults should now be highlighted
    • Workaround:
      Hide

      Add the following to formal_white.css

      .capdefault

      {background-color:#DDDDDD;border: 1px solid #CECECE;}

      Or what other style you want.

      Show
      Add the following to formal_white.css .capdefault {background-color:#DDDDDD;border: 1px solid #CECECE;} Or what other style you want.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29403_master
    • Rank:
      19111

      Description

      When theme FORMAL WHITE is selected, default values of roles are not shown.

      Replication steps:

      1. Select theme FORMAL WHITE
      2. Go to Home->Site administration->Users->Permissions->Define roles and edit a role

      Default values are not shown (highlighted) for each capability.

      1. screen1.png
        30 kB
      2. screen2.png
        23 kB

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
          Hide
          Christos Rodosthenous added a comment -

          I also have a solution to this:

          Add the folowing to formal_white.css

          .capdefault

          {background-color:#DDDDDD;border: 1px solid #CECECE;}

          Or what other style you want.

          Show
          Christos Rodosthenous added a comment - I also have a solution to this: Add the folowing to formal_white.css .capdefault {background-color:#DDDDDD;border: 1px solid #CECECE;} Or what other style you want.
          Hide
          Daniele Cordella added a comment -

          Thanks Mary. I had no info about this bug. Thanks for your workaround.

          Show
          Daniele Cordella added a comment - Thanks Mary. I had no info about this bug. Thanks for your workaround.
          Hide
          Mary Evans added a comment -

          You're welcome Daniele. I have just spent an hour or so going through all the bugs I did not know about either.

          By default ALL theme related issues are assigned to Patrick, as he is Theme Manager, but he is incognito at present so I was supposed to receive notifications instead, but that is not happening. There are lots more issues which need reassigning...I only filtered the issues from 27th April when we started this new system for integration and such.

          I'll go through all the others later when I have cleared this backlog.

          John Stabinger is helping fix things too, but he is very busy right now with work.

          The workaround for this issue was added by Christos who reported the problem. I did not test it, but I suspect it is correct. Personally I am not sure why it is not showing up by default, since one would suspect it should come from one or other of the parent themes. Ah well perhaps not! LOL

          Show
          Mary Evans added a comment - You're welcome Daniele. I have just spent an hour or so going through all the bugs I did not know about either. By default ALL theme related issues are assigned to Patrick, as he is Theme Manager, but he is incognito at present so I was supposed to receive notifications instead, but that is not happening. There are lots more issues which need reassigning...I only filtered the issues from 27th April when we started this new system for integration and such. I'll go through all the others later when I have cleared this backlog. John Stabinger is helping fix things too, but he is very busy right now with work. The workaround for this issue was added by Christos who reported the problem. I did not test it, but I suspect it is correct. Personally I am not sure why it is not showing up by default, since one would suspect it should come from one or other of the parent themes. Ah well perhaps not! LOL
          Hide
          Daniele Cordella added a comment -

          @Mary:
          I would have time to make further investigation on this issue too but without time availability I only have to agree with your words: "Personally I am not sure why it is not showing up by default, since one would suspect it should come from one or other of the parent themes".

          BTW: Tomorrow I'll be travelling but on Saturday night or Sunday I would ask for integration MDL-28458. Do you agree with the solution?
          Ciao and thanks again!

          Show
          Daniele Cordella added a comment - @Mary: I would have time to make further investigation on this issue too but without time availability I only have to agree with your words: "Personally I am not sure why it is not showing up by default, since one would suspect it should come from one or other of the parent themes". BTW: Tomorrow I'll be travelling but on Saturday night or Sunday I would ask for integration MDL-28458 . Do you agree with the solution? Ciao and thanks again!
          Hide
          Mary Evans added a comment -

          This looks OK to me Daniele.

          I think it might be worth me seeing if I could add something similar to BASE theme, perhaps some faint lines to show where the columns are, but I am not sure if I would be allowed to add color to the columns too. I will need to check on this.

          Anyway...this is looking good. So hopefully it will be integrated soon.

          Thanks

          Show
          Mary Evans added a comment - This looks OK to me Daniele. I think it might be worth me seeing if I could add something similar to BASE theme, perhaps some faint lines to show where the columns are, but I am not sure if I would be allowed to add color to the columns too. I will need to check on this. Anyway...this is looking good. So hopefully it will be integrated soon. Thanks
          Hide
          Sam Hemelryk added a comment -

          Thanks Daniele - this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Daniele - this has been integrated now
          Hide
          Rajesh Taneja added a comment -

          Thanks Daniele, Looks great now

          There are few things I notices while testing this:
          1. MDL comment is added in css, which probably can be removed.
          2. We have capdefault defined in standard theme

          theme/standard/style/admin.css - line:128
          #page-admin-roles-define .capdefault {background-color:#DDDDDD;border: 1px solid #CECECE;}
          

          So for consistency purpose current solution can use "#page-admin-roles-define .capdefault" rather then ".capdefault"

          Passing this as this solves the issue

          Show
          Rajesh Taneja added a comment - Thanks Daniele, Looks great now There are few things I notices while testing this: 1. MDL comment is added in css, which probably can be removed. 2. We have capdefault defined in standard theme theme/standard/style/admin.css - line:128 #page-admin-roles-define .capdefault {background-color:#DDDDDD;border: 1px solid #CECECE;} So for consistency purpose current solution can use "#page-admin-roles-define .capdefault" rather then ".capdefault" Passing this as this solves the issue
          Hide
          Daniele Cordella added a comment -

          Thanks Rajesh.
          Please feel free to use your better defined style selector ("#page-admin-roles-define .capdefault" rather then ".capdefault").

          About MDL comment, I intentionally added it to CSS but, once again, if you feel it is better to take it out, please delete it.

          Thanks everybody.

          Show
          Daniele Cordella added a comment - Thanks Rajesh. Please feel free to use your better defined style selector ("#page-admin-roles-define .capdefault" rather then ".capdefault"). About MDL comment, I intentionally added it to CSS but, once again, if you feel it is better to take it out, please delete it. Thanks everybody.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          git repositories have been updated with your awesome changes, thanks! Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: