Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29390 DB layer improvements 2.2 META
  3. MDL-29416

Post MDL-29322 : create one XMLDB report to allow admins to change the whole DB to CHAR semantics

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 2.2
    • 2.2
    • Database SQL/XMLDB
    • MOODLE_22_STABLE
    • MOODLE_22_STABLE
    • Hide

      Oracle DB needed:

      1) Install Moodle 2.2 (master) from scratch

      2) Run Admin -> Development -> XMLDB Editor -> Check semantics
      3) TEST: 0 wrong semantics found with message about no further actions needed.
      4) TEST: The detailed log shows all columns with Ok message.

      5) Install Moodle 2.1 (21_STABLE) from scratch and upgrade to Moodle 2.2 (master)
      6) Run Admin -> Development -> XMLDB Editor -> Check semantics
      7) TEST: Some wrong semantics will be found. Annotate the number.
      8) TEST: The detailed log shows columns with Ok message and columns with current/expected message

      9) Pick some (not all) of the SQL suggested code. Annotate the number.
      10) Execute it against the DB in your fav. interface
      11) TEST: The alter table statements are executed without error.

      12) Run again Admin -> Development -> XMLDB Editor -> Check semantics
      13) TEST: The number of wrong semantics = the annotated @ point 7 - 9 above

      14) Execute all the remaining SQL statements.
      15) TEST: All them are executed without error.

      16) Run again Admin -> Development -> XMLDB Editor -> Check semantics
      17) TEST: 0 wrong semantics found with message about no further actions needed.

      18) Run all DB functional tests against Oracle.
      19) TEST: Only the well-known "concat not ansi" one should fail.

      That is, thanks!

      Show
      Oracle DB needed: 1) Install Moodle 2.2 (master) from scratch 2) Run Admin -> Development -> XMLDB Editor -> Check semantics 3) TEST: 0 wrong semantics found with message about no further actions needed. 4) TEST: The detailed log shows all columns with Ok message. 5) Install Moodle 2.1 (21_STABLE) from scratch and upgrade to Moodle 2.2 (master) 6) Run Admin -> Development -> XMLDB Editor -> Check semantics 7) TEST: Some wrong semantics will be found. Annotate the number. 8) TEST: The detailed log shows columns with Ok message and columns with current/expected message 9) Pick some (not all) of the SQL suggested code. Annotate the number. 10) Execute it against the DB in your fav. interface 11) TEST: The alter table statements are executed without error. 12) Run again Admin -> Development -> XMLDB Editor -> Check semantics 13) TEST: The number of wrong semantics = the annotated @ point 7 - 9 above 14) Execute all the remaining SQL statements. 15) TEST: All them are executed without error. 16) Run again Admin -> Development -> XMLDB Editor -> Check semantics 17) TEST: 0 wrong semantics found with message about no further actions needed. 18) Run all DB functional tests against Oracle. 19) TEST: Only the well-known "concat not ansi" one should fail. That is, thanks!

      The change of semantics from BYTE to CHAR @ MDL-29322, causes new columns to be always created with CHAR semantics, but old ones will remain as BYTE semantics.

      So we need to:

      1) Create one XMLDB report for Oracle in order to provide all the DDL statements to change all columns to CHAR semantics.
      2) Document everything in release notes.

        1. oracle_func_db_test_results.tar.gz
          220 kB

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Sam Hemelryk Sam Hemelryk
            Aparup Banerjee Aparup Banerjee
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.