Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29420

Coding Error in Advanced Global search

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.4, 2.1.1
          • Fix Version/s: 2.0.6, 2.1.3
          • Component/s: Global search
          • Labels:
          • Testing Instructions:
            Hide
            1. Enable global search from site administration>development>experimental
            2. add a global search block to any page
            3. Do a search
            4. click on advanced search on the results page.
            5. Do a search
            6. Make sure you dont get any error!
            Show
            Enable global search from site administration>development>experimental add a global search block to any page Do a search click on advanced search on the results page. Do a search Make sure you dont get any error!
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull from Repository:

            Description

            While working on MDL-19575 I found the following issue with advanced search:-
            When using global search click on "Advanced search". It throws up an Coding error.

            Stack trace:

            line 6468 of \lib\moodlelib.php: coding_exception thrown
            line 6542 of \lib\moodlelib.php: call to get_string()
            line 227 of \search\query.php: call to print_string()

            First Guess:-
            string identifier 'whichmodulestosearch?' is causing this issue (the ?)

              Gliffy Diagrams

                Attachments

                  Issue Links

                  duplicates

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25415 Coding error in global search

                  • Major - Major loss of function, incorrect output
                  • Closed

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-25905 Advanced Global search coding error

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment - - edited

                    screenshot attached

                    Show
                    ankit_frenz Ankit Agarwal added a comment - - edited screenshot attached
                    Hide
                    Permalink
                    vaughany Paul Vaughan added a comment -

                    This issue affects us but I added comments to the duplicate report.

                    Show
                    vaughany Paul Vaughan added a comment - This issue affects us but I added comments to the duplicate report.
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    Hi Paul,
                    Yes Looks like this issue has been reported a lot of times. I will make sure this gets fixed soon.
                    Thanks for reporting the issue, helps us make Moodle better.

                    Cheers
                    Ankit

                    Show
                    ankit_frenz Ankit Agarwal added a comment - Hi Paul, Yes Looks like this issue has been reported a lot of times. I will make sure this gets fixed soon. Thanks for reporting the issue, helps us make Moodle better. Cheers Ankit
                    Hide
                    Permalink
                    phalacee Jason Fowler added a comment -

                    Code is good, straight forward change, ready to go

                    Show
                    phalacee Jason Fowler added a comment - Code is good, straight forward change, ready to go
                    Hide
                    Permalink
                    ankit_frenz Ankit Agarwal added a comment -

                    Thanks Jason!
                    Up for integration!

                    Thanks

                    Show
                    ankit_frenz Ankit Agarwal added a comment - Thanks Jason! Up for integration! Thanks
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks guys this has been integrated now. Testers this isn't applicable to master.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks guys this has been integrated now. Testers this isn't applicable to master.
                    Hide
                    Permalink
                    abgreeve Adrian Greeve added a comment -

                    The patch works fine.

                    Show
                    abgreeve Adrian Greeve added a comment - The patch works fine.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks!

                    Ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Yes, you got this finally upstream, just in time for Moodle 2.2beta. Congrats and thanks! Ciao

                      People

                      • Votes:
                        3 Vote for this issue
                        Watchers:
                        3 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          28/Nov/11