Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29422

Access restriction dates for activities can be changed inadvertently when users with different timezones save changes to the activity

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Duplicate
    • Affects Version/s: 2.0.2
    • Fix Version/s: None
    • Component/s: Activity completion
    • Labels:
      None
    • Testing Instructions:
      Hide
      • Ensure "Enable conditional access" is set.

      As a user with their timezone set to Melbourne, Australia:

      • Create an assignment and set access restriction dates to 20 November 2011 and 21 November 2011. (At this point, one would expect the assignment to be available for 48 hours, from 0:00 on 20/11 to 11:59 on 21/11)
      • observe the information shown under the activity is as follows:
        "Restricted: 'Available from 19 November 2011 to 21 November 2011.'"

      As a user with edit access and their timezone set to Adelaide, Australia:

      • Observe the restriction information:
        "Restricted: 'Available from 19 November 2011, 11:30 PM to 21 November 2011, 11:29 PM.'"
        This is as expected given the timezone is different by half an hour, and is still a 48 hour period.
      • Edit the assignment and save without making any changes
      • Observe the restriction information:
        "Restricted: 'Available from 19 November 2011 to 21 November 2011.'"
        The assignment is now available from 0:00 on 19/11 to 23:59 on 21/11, a 72 hour period. I would expect the dates to remain the same, however, this most likely isn't possible without including times as well as dates for access restriction
      Show
      Ensure "Enable conditional access" is set. As a user with their timezone set to Melbourne, Australia: Create an assignment and set access restriction dates to 20 November 2011 and 21 November 2011. (At this point, one would expect the assignment to be available for 48 hours, from 0:00 on 20/11 to 11:59 on 21/11) observe the information shown under the activity is as follows: "Restricted: 'Available from 19 November 2011 to 21 November 2011.'" As a user with edit access and their timezone set to Adelaide, Australia: Observe the restriction information: "Restricted: 'Available from 19 November 2011, 11:30 PM to 21 November 2011, 11:29 PM.'" This is as expected given the timezone is different by half an hour, and is still a 48 hour period. Edit the assignment and save without making any changes Observe the restriction information: "Restricted: 'Available from 19 November 2011 to 21 November 2011.'" The assignment is now available from 0:00 on 19/11 to 23:59 on 21/11, a 72 hour period. I would expect the dates to remain the same, however, this most likely isn't possible without including times as well as dates for access restriction
    • Affected Branches:
      MOODLE_20_STABLE

      Description

      With "Enable conditional access" set, activities will have a "Restrict access" section within which access to the activities can be restricted by (amongst other things) date. If, however, users with different timezones update an assignment after one another, either the 'from', or the 'until' date will be changed by a day (which one is changed depends on whether the user who saved first had a timezone ahead of, or behind the user who saved second).

      This is the behaviour after the patch from MDL-28992 has been applied. Testing will likely be somewhat confusing, but the issue still exists even if that patch hasn't been applied.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                quen Sam Marshall
                Reporter:
                monash-vle Monash University VLE team
                Participants:
                Component watchers:
                Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: