Moodle
  1. Moodle
  2. MDL-29427

Information items should summarise the state as 'viewed' or 'not yet viewed'

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Accessibility, Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Attempt a quiz that contains some 'descriptions'.

      Verify that the little [i] button in the question navigation has a tool-tip that is either 'not yet viewed' or 'viewed' depending on whether the button is grey or not.

      Show
      Attempt a quiz that contains some 'descriptions'. Verify that the little [i] button in the question navigation has a tool-tip that is either 'not yet viewed' or 'viewed' depending on whether the button is grey or not.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19388

      Description

      This affects the quiz navigation, and was reported by our accessibility export.

      (She also points out that we should avoid the word 'read' which sounds like 'red'.)

        Activity

        Hide
        Tim Hunt added a comment -

        Note that we want this to appear as the tool-tip in the quiz navigation. We don't want this status to appear on the grey information panel beside the question.

        Therefore, this needs to be done in quiz_nav_panel_base::get_question_buttons, not in qbehaviour_informationitem::get_state_string.

        Show
        Tim Hunt added a comment - Note that we want this to appear as the tool-tip in the quiz navigation. We don't want this status to appear on the grey information panel beside the question. Therefore, this needs to be done in quiz_nav_panel_base::get_question_buttons, not in qbehaviour_informationitem::get_state_string.
        Hide
        Tim Hunt added a comment -

        Note: this change was recommended by Chetz Colwell, accessibility expert at the OU.

        Show
        Tim Hunt added a comment - Note: this change was recommended by Chetz Colwell, accessibility expert at the OU.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        I guess (hope) only description questions have length = 0. Or, in other words, we want the viewed / not viewed state string for ALL length = 0 qtypes. Given the title of the issues sounded more "natural" to decide based exactly on qtype (class?) and not in that property.

        Integrated anyway. You know way more than me, lol. Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - I guess (hope) only description questions have length = 0. Or, in other words, we want the viewed / not viewed state string for ALL length = 0 qtypes. Given the title of the issues sounded more "natural" to decide based exactly on qtype (class?) and not in that property. Integrated anyway. You know way more than me, lol. Thanks!
        Hide
        Tim Hunt added a comment -

        The issue summary is designed to contain the type of keywords people might search for. Length = 0 is the correct logic. For example, look at how the quiz decided whether to use 'i' or a question number for each question. The think is that people may choose to create other description-like question types. Of course, it might be clearer to define a question_type::is_not_a_real_question() method, but that has never been used in the past.

        Show
        Tim Hunt added a comment - The issue summary is designed to contain the type of keywords people might search for. Length = 0 is the correct logic. For example, look at how the quiz decided whether to use 'i' or a question number for each question. The think is that people may choose to create other description-like question types. Of course, it might be clearer to define a question_type::is_not_a_real_question() method, but that has never been used in the past.
        Hide
        Sam Hemelryk added a comment -

        Thanks guys tests passed

        Show
        Sam Hemelryk added a comment - Thanks guys tests passed
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Thanks for explanation, Tim!

        Show
        Eloy Lafuente (stronk7) added a comment - Thanks for explanation, Tim!
        Hide
        Aparup Banerjee added a comment -

        fixes have been rolled merrily up the stream! Thanks everybody!

        Show
        Aparup Banerjee added a comment - fixes have been rolled merrily up the stream! Thanks everybody!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: