Moodle
  1. Moodle
  2. MDL-29441

Chat window does not pop up for separate groups in IE7-9

    Details

    • Testing Instructions:
      Hide

      This should be completed both with debugging enabled, and disabled.

      Using a selection of browers (not just IE):

      • create a chat
      • create a number of groups in a course
      • open that chat up as a user with access to multiple groups (e.g. a teacher)
      • select a group to access the chat with
      • select the "Click here to enter the chat now" link
        • Confirm that the popup was opened correctly and no warnings were shown in the browser
        • If debugging was set Confirm that no JavaScript alerts were shown
      • Repeat with the "Use more accessible interface" link
        • Confirm that the popup was opened correctly and no warnings were shown in the browser
        • If debugging was set Confirm that no JavaScript alerts were shown
      Show
      This should be completed both with debugging enabled, and disabled. Using a selection of browers (not just IE): create a chat create a number of groups in a course open that chat up as a user with access to multiple groups (e.g. a teacher) select a group to access the chat with select the "Click here to enter the chat now" link Confirm that the popup was opened correctly and no warnings were shown in the browser If debugging was set Confirm that no JavaScript alerts were shown Repeat with the "Use more accessible interface" link Confirm that the popup was opened correctly and no warnings were shown in the browser If debugging was set Confirm that no JavaScript alerts were shown
    • Workaround:
      Hide

      Workaround options:
      1. Upgrade IE to IE10.
      2. Use a different browser, such as Chrome or Firefox.
      3. Don't use separate groups.

      Show
      Workaround options: 1. Upgrade IE to IE10. 2. Use a different browser, such as Chrome or Firefox. 3. Don't use separate groups.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull 2.4 Branch:
    • Pull 2.5 Branch:
    • Pull Master Branch:
      MDL-29441-master
    • Story Points:
      4
    • Rank:
      18948
    • Sprint:
      FRONTEND Sprint 6

      Description

      Using separate groups and IE7, 8 or 9, when you click to enter the chat it does nothing. If you select All Groups you can enter the chat.

      Replication steps:

      1. Setup 2 groups
      2. Go to a chat where the group mode is "Separate groups"
      3. In the upper left corner, select a group
      4. Try to enter the chat
      1. doesntwork.PNG
        10 kB
      2. works.PNG
        11 kB

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          I was able to replicate this.

          In FF there was no problem. In IE, with debugging turned on, I received the following error, but only once.

          Did you remember to make the first column something unique in your call to get_records? Duplicate value '2' found in column 'id'.
          line 803 of \lib\dml\mysqli_native_moodle_database.php: call to debugging()
          line 546 of \mod\chat\lib.php: call to mysqli_native_moodle_database->get_records_sql()
          line 1279 of \mod\chat\lib.php: call to chat_get_users()
          line 1797 of \lib\navigationlib.php: call to chat_extend_navigation()
          line 1208 of \lib\navigationlib.php: call to global_navigation->load_activity()
          line 2616 of \lib\navigationlib.php: call to global_navigation->initialise()
          line 659 of \lib\pagelib.php: call to navbar->has_items()
          line 4 of \theme\base\layout\general.php: call to moodle_page->has_navbar()
          line 685 of \lib\outputrenderers.php: call to include()
          line 637 of \lib\outputrenderers.php: call to core_renderer->render_page_layout()
          line ? of unknownfile: call to core_renderer->header()
          line 1291 of \lib\setuplib.php: call to call_user_func_array()
          line 92 of \mod\chat\view.php: call to bootstrap_renderer->__call()
          line 92 of \mod\chat\view.php: call to bootstrap_renderer->header()

          The pop-up seemed to work with all participants, but not individual groups.

          Show
          Michael de Raadt added a comment - I was able to replicate this. In FF there was no problem. In IE, with debugging turned on, I received the following error, but only once. Did you remember to make the first column something unique in your call to get_records? Duplicate value '2' found in column 'id'. line 803 of \lib\dml\mysqli_native_moodle_database.php: call to debugging() line 546 of \mod\chat\lib.php: call to mysqli_native_moodle_database->get_records_sql() line 1279 of \mod\chat\lib.php: call to chat_get_users() line 1797 of \lib\navigationlib.php: call to chat_extend_navigation() line 1208 of \lib\navigationlib.php: call to global_navigation->load_activity() line 2616 of \lib\navigationlib.php: call to global_navigation->initialise() line 659 of \lib\pagelib.php: call to navbar->has_items() line 4 of \theme\base\layout\general.php: call to moodle_page->has_navbar() line 685 of \lib\outputrenderers.php: call to include() line 637 of \lib\outputrenderers.php: call to core_renderer->render_page_layout() line ? of unknownfile: call to core_renderer->header() line 1291 of \lib\setuplib.php: call to call_user_func_array() line 92 of \mod\chat\view.php: call to bootstrap_renderer->__call() line 92 of \mod\chat\view.php: call to bootstrap_renderer->header() The pop-up seemed to work with all participants, but not individual groups.
          Hide
          Yvonne Hamilton added a comment -

          Hi,

          We are on Moodle 2.1.3 and this doesn't work for separate groups or for visible groups in IE8...haven't tested in IE7 or 9 but guess its the same.

          Participants cannot access the 'All participants' group when assigned to 'separate groups' so it is useless to students in that mode.
          'Visible groups' they can access only via 'All participants'option which is pointless so at the momenet the Chat needs to be set to 'No groups' for it to be usable by students or get them to install another browser (not an option for us with PC's locked down by group policy)

          Show
          Yvonne Hamilton added a comment - Hi, We are on Moodle 2.1.3 and this doesn't work for separate groups or for visible groups in IE8...haven't tested in IE7 or 9 but guess its the same. Participants cannot access the 'All participants' group when assigned to 'separate groups' so it is useless to students in that mode. 'Visible groups' they can access only via 'All participants'option which is pointless so at the momenet the Chat needs to be set to 'No groups' for it to be usable by students or get them to install another browser (not an option for us with PC's locked down by group policy)
          Hide
          Chris Follin added a comment -

          This is still a problem in 2.3.3 with IE7-9. It is not a problem in 2.3.3 with IE10 running in IE10 mode, but is a problem when IE10 is running in IE8, IE9, or IE10 Compatibility modes.

          Show
          Chris Follin added a comment - This is still a problem in 2.3.3 with IE7-9. It is not a problem in 2.3.3 with IE10 running in IE10 mode, but is a problem when IE10 is running in IE8, IE9, or IE10 Compatibility modes.
          Hide
          Michael de Raadt added a comment -

          This issue is affecting supported versions, so I'm bumping the issue and opening it up.

          Show
          Michael de Raadt added a comment - This issue is affecting supported versions, so I'm bumping the issue and opening it up.
          Hide
          Michael de Raadt added a comment -

          Andrew. I've added you as a watcher, in case you are interested in this issue.

          Show
          Michael de Raadt added a comment - Andrew. I've added you as a watcher, in case you are interested in this issue.
          Hide
          Andrew Nicols added a comment -

          This is due to an invalid name for the action.

          Show
          Andrew Nicols added a comment - This is due to an invalid name for the action.
          Hide
          Andrew Nicols added a comment -

          For the record, I considered changing the alert to a Y.log, but I'm on the fence as to whether this should be done or not. Ultimately, I guess so, but I think we need to be aware of the issues and fix them.

          Show
          Andrew Nicols added a comment - For the record, I considered changing the alert to a Y.log, but I'm on the fence as to whether this should be done or not. Ultimately, I guess so, but I think we need to be aware of the issues and fix them.
          Hide
          Andrew Davis added a comment -

          Repeat both with debug = (E_ALL | E_STRICT) (DEBUG_DEVELOPER) enabled
          Confirm that no warnings about inappropriate names were displayed

          I'm curious about this. Are you suggesting that the testing should be done with debugging turned off initially? If so, why?

          Otherwise, it looks fine. just need to clarify what you mean in the testing instructions.

          Show
          Andrew Davis added a comment - Repeat both with debug = (E_ALL | E_STRICT) (DEBUG_DEVELOPER) enabled Confirm that no warnings about inappropriate names were displayed I'm curious about this. Are you suggesting that the testing should be done with debugging turned off initially? If so, why? Otherwise, it looks fine. just need to clarify what you mean in the testing instructions.
          Hide
          Andrew Nicols added a comment -

          Hmm, probably doesn't need to be done both ways, but it should definitely be done with debugging enabled at the least because an error message is displayed (via alert).
          I'd prefer to test both though because we should ideally be testing without debugging, as this is what the users will normally be using.

          Show
          Andrew Nicols added a comment - Hmm, probably doesn't need to be done both ways, but it should definitely be done with debugging enabled at the least because an error message is displayed (via alert). I'd prefer to test both though because we should ideally be testing without debugging, as this is what the users will normally be using.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 25 and 24 - thanks Andrew

          Show
          Dan Poltawski added a comment - Integrated to master, 25 and 24 - thanks Andrew
          Hide
          Damyon Wiese added a comment -

          Passing test. I tested this on 24, 25 and master in chrome, firefox, ie7, 8 9 and 10.

          I did get the duplicate record warning - even on master. I'm disregarding that as there is an issue for it already and it is not the point of this fix (but it does need fixing).

          Show
          Damyon Wiese added a comment - Passing test. I tested this on 24, 25 and master in chrome, firefox, ie7, 8 9 and 10. I did get the duplicate record warning - even on master. I'm disregarding that as there is an issue for it already and it is not the point of this fix (but it does need fixing).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          "Aequam memento rebus in arduis servare mentem"

          Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - "Aequam memento rebus in arduis servare mentem" Many thanks for your hard work, this is now part of "Moodle, the LMS". Closing! Ciao

            People

            • Votes:
              9 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile