Moodle
  1. Moodle
  2. MDL-29454

Questions types can not be edited by admin on IE8, IE9 FF5, FF6

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Given the nature of the change, you need to test all the functionality provided by admin/qtypes.php.

      Show
      Given the nature of the change, you need to test all the functionality provided by admin/qtypes.php.
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE
    • Pull from Repository:

      Description

      Issue: When you go to

      {site}

      /admin/qtypes/php it will not allow you to close or open the eye or use the arrows

      You CAN do it on the following browsers:
      Chrome
      Firefox 3

      You CANNOT on the following browsers:
      IE8, IE9
      FF5, FF6

      We tested this on several sites, this is not theme related, we have changed themes and problem still occurs.

        Gliffy Diagrams

          Activity

          Hide
          Tim Hunt added a comment -

          Well, it works for me on Firefox 7. I find your report very difficult to believe, because these icons are just standard HTML links. There is nothing fancy going on in the web browser. All the hard work takes place on the server.

          Of course, you must be seeing it, or you would not bother to have reported it. I am just saying that it makes no sense, so I don't know where to start in trying to fix it.

          What does happen when you click one of the arrows? (Please try with http://docs.moodle.org/20/en/Debugging turned up to DEVELOPER level.) Thanks.

          Show
          Tim Hunt added a comment - Well, it works for me on Firefox 7. I find your report very difficult to believe, because these icons are just standard HTML links. There is nothing fancy going on in the web browser. All the hard work takes place on the server. Of course, you must be seeing it, or you would not bother to have reported it. I am just saying that it makes no sense, so I don't know where to start in trying to fix it. What does happen when you click one of the arrows? (Please try with http://docs.moodle.org/20/en/Debugging turned up to DEVELOPER level.) Thanks.
          Hide
          Kevin McCarthy added a comment - - edited

          Same thing happens when you click on the arrows, nothing happens

          Show
          Kevin McCarthy added a comment - - edited Same thing happens when you click on the arrows, nothing happens
          Hide
          Tim Hunt added a comment -

          Just tested here where I have IE8, and it still all works for me. You will have to give me some useful information if you want me to do anything.

          Show
          Tim Hunt added a comment - Just tested here where I have IE8, and it still all works for me. You will have to give me some useful information if you want me to do anything.
          Hide
          Chris Follin added a comment -

          I'm seeing the problem in Firefox 6. Clicking an eye icon or any of the arrows refreshes the page but after the refresh, nothing is different. The question type wasn't hidden or reordered as intended.

          Show
          Chris Follin added a comment - I'm seeing the problem in Firefox 6. Clicking an eye icon or any of the arrows refreshes the page but after the refresh, nothing is different. The question type wasn't hidden or reordered as intended.
          Hide
          Tim Hunt added a comment -

          Not that these settings are stored in the database in the config_plugins table. You need rows where the component is 'question'. If the worst comes to the worst you can always edit those values manually.

          Show
          Tim Hunt added a comment - Not that these settings are stored in the database in the config_plugins table. You need rows where the component is 'question'. If the worst comes to the worst you can always edit those values manually.
          Hide
          Chris Follin added a comment -

          Tim, our clients don't have direct access to their databases and it is not acceptable to them or to us that they would need to submit a support ticket to change values in the database for settings that are available through the interface but do not work in multiple browsers. Using a different browser, such as Chrome, is not always acceptable either as many schools have standardized computer environments and do not allow users to install additional software.

          Also, I tested Chrome on the same site of mine. Chrome 14 works. Firefox 6 does not.

          Show
          Chris Follin added a comment - Tim, our clients don't have direct access to their databases and it is not acceptable to them or to us that they would need to submit a support ticket to change values in the database for settings that are available through the interface but do not work in multiple browsers. Using a different browser, such as Chrome, is not always acceptable either as many schools have standardized computer environments and do not allow users to install additional software. Also, I tested Chrome on the same site of mine. Chrome 14 works. Firefox 6 does not.
          Hide
          Tim Hunt added a comment -

          You have access to the DB. You have the ability to investigate what is going on. You should know that 'It does not work' is not likely to be enough information to diagnose and fix a bug.

          Show
          Tim Hunt added a comment - You have access to the DB. You have the ability to investigate what is going on. You should know that 'It does not work' is not likely to be enough information to diagnose and fix a bug.
          Hide
          Kevin McCarthy added a comment -
          Show
          Kevin McCarthy added a comment - http://screencast.com/t/rzXTxMxcB
          Hide
          Tim Hunt added a comment - - edited

          Unless I get some real hard information about what is going on, I am going to have to close this cannot reproduce.

          Show
          Tim Hunt added a comment - - edited Unless I get some real hard information about what is going on, I am going to have to close this cannot reproduce.
          Hide
          Chris Follin added a comment - - edited

          Tim, I'm using the example of trying to disable the calculatedmulti question type but this is happening for all disable, up, and down actions.

          In Firefox, the disable=calculatedmulti post variable is not set. Line 55 of admin/qtypes.php:

          if (($disable = optional_param('disable', '', PARAM_SAFEDIR)) && confirm_sesskey()) {

          is skipped because optional_param() doesn't find 'disable' to be set. POST has sesskey, disable.x, and disable.y but no disable.

          In Chrome, disable=calculatedmulti is set and it works as expected. I do not know why the post variable is not getting set in Firefox.

          Show
          Chris Follin added a comment - - edited Tim, I'm using the example of trying to disable the calculatedmulti question type but this is happening for all disable, up, and down actions. In Firefox, the disable=calculatedmulti post variable is not set. Line 55 of admin/qtypes.php: if (($disable = optional_param('disable', '', PARAM_SAFEDIR)) && confirm_sesskey()) { is skipped because optional_param() doesn't find 'disable' to be set. POST has sesskey, disable.x, and disable.y but no disable. In Chrome, disable=calculatedmulti is set and it works as expected. I do not know why the post variable is not getting set in Firefox.
          Hide
          Tim Hunt added a comment -

          Ah! so perhaps this got broken by the recent change to optional_param_array? No, actually, that would not have exactly those symptoms. Anyway, now I have some idea what is going on there, I should be able to reproduce it. Thank you for providing the extra information.

          Show
          Tim Hunt added a comment - Ah! so perhaps this got broken by the recent change to optional_param_array? No, actually, that would not have exactly those symptoms. Anyway, now I have some idea what is going on there, I should be able to reproduce it. Thank you for providing the extra information.
          Hide
          Tim Hunt added a comment -

          OK, so it looks like this page changed between 2.0 and 2.1. In 2.1 the icons on that page are plain <a href="..."><img ...></a> so the changes are done with get requests and just work.

          Yes, and in 2.0 they are input type=image.

          I guess a suggested work-around of "Upgrade to 2.1" is not going to make me popular. I wonder how much work it will be to back-port the 2.1 code?.

          Show
          Tim Hunt added a comment - OK, so it looks like this page changed between 2.0 and 2.1. In 2.1 the icons on that page are plain <a href="..."><img ...></a> so the changes are done with get requests and just work. Yes, and in 2.0 they are input type=image. I guess a suggested work-around of "Upgrade to 2.1" is not going to make me popular. I wonder how much work it will be to back-port the 2.1 code?.
          Hide
          Tim Hunt added a comment -

          So, I have done a fix by back-porting the working code from 2.1. Unfortunately, between 2.0 and 2.1 the coding style was changed, which makes the diff completely unreadable.

          I am not sure that this is the 'right' way to do this fix. I will consult with the integrators. In the mean time, it would be useful if anyone could test this new code (it seems to work for me).

          Show
          Tim Hunt added a comment - So, I have done a fix by back-porting the working code from 2.1. Unfortunately, between 2.0 and 2.1 the coding style was changed, which makes the diff completely unreadable. I am not sure that this is the 'right' way to do this fix. I will consult with the integrators. In the mean time, it would be useful if anyone could test this new code (it seems to work for me).
          Hide
          Tim Hunt added a comment -

          Eloy, please could you look at my proposed fix (read the commit comment) and tell me if you would be prepared to integrate that? Thanks.

          Show
          Tim Hunt added a comment - Eloy, please could you look at my proposed fix (read the commit comment) and tell me if you would be prepared to integrate that? Thanks.
          Hide
          Chris Follin added a comment -

          I tested the fix in Firefox and Chrome. Chrome continues to work as it did before and Firefox now works where it did not before. The eye and arrow icons all work for their intended purposes. Thanks, Tim, for the fix.

          Show
          Chris Follin added a comment - I tested the fix in Firefox and Chrome. Chrome continues to work as it did before and Firefox now works where it did not before. The eye and arrow icons all work for their intended purposes. Thanks, Tim, for the fix.
          Hide
          Tim Hunt added a comment -

          Following a discussion with Eloy in developer chat, I need to break this into two commits.
          1. that fixes the whitespace, and then
          2. that makes any real changes to the code.

          Then there is some chance it may actually be reviewable.

          Show
          Tim Hunt added a comment - Following a discussion with Eloy in developer chat, I need to break this into two commits. 1. that fixes the whitespace, and then 2. that makes any real changes to the code. Then there is some chance it may actually be reviewable.
          Hide
          Tim Hunt added a comment -

          OK, branch re-based to be two commits. I think (hope) it is now reviewable/integratable.

          Show
          Tim Hunt added a comment - OK, branch re-based to be two commits. I think (hope) it is now reviewable/integratable.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Tim, this has been integrated now

          Today I learnt that the moodle_url searches for and replaces /admin/ if $CFG->admin is not /admin/

          Show
          Sam Hemelryk added a comment - Thanks Tim, this has been integrated now Today I learnt that the moodle_url searches for and replaces /admin/ if $CFG->admin is not /admin/
          Hide
          Tim Hunt added a comment -

          Surely you already knew that?! (That was Petr's clever idea.)

          Anyway, glad to have been educational

          Show
          Tim Hunt added a comment - Surely you already knew that?! (That was Petr's clever idea.) Anyway, glad to have been educational
          Hide
          Aparup Banerjee added a comment - - edited

          I'm not so sure i could have possibly tested all funcitonality but things seem to work for me so passing. also this was somewhat tested by participants here.

          It quiet difficult really to be a tester thats told to test 'all functionality', even a link to a doc would help narrow it down.

          Show
          Aparup Banerjee added a comment - - edited I'm not so sure i could have possibly tested all funcitonality but things seem to work for me so passing. also this was somewhat tested by participants here. It quiet difficult really to be a tester thats told to test 'all functionality', even a link to a doc would help narrow it down.
          Hide
          Tim Hunt added a comment -

          Don't we have a set of QA tests for this page? Can't you use those?

          Show
          Tim Hunt added a comment - Don't we have a set of QA tests for this page? Can't you use those?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

            People

            • Votes:
              12 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: