Moodle
  1. Moodle
  2. MDL-29471

error when adding function to a new web service

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.1.4, 2.2.1, 2.3
        • Fix Version/s: 2.1.5, 2.2.2
        • Component/s: Web Services
        • Labels:
        • Testing Instructions:
          Hide

          1- Create a service (Admin > Plugins > Web service > Manage service)
          2- Add few functions to service

          You never seen the error message:

          Invalid array parameter detected in required_param(): fid

          Show
          1- Create a service (Admin > Plugins > Web service > Manage service) 2- Add few functions to service You never seen the error message: Invalid array parameter detected in required_param(): fid
        • Affected Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE
        • Pull from Repository:
        • Pull Master Branch:
        • Pull Master Diff URL:
        • Rank:
          19181

          Description

          Invalid array parameter detected in required_param(): fid

          line 558 of /lib/moodlelib.php: call to debugging()
          line 32 of /admin/webservice/service_functions.php: call to optional_param()

          Notice: Undefined property: stdClass::$fid in /home/aparup/mcode/22/mysql/admin/webservice/service_functions.php on line 70 Warning: Invalid argument supplied for foreach() in /home/aparup/mcode/22/mysql/admin/webservice/service_functions.php on line 70

            Issue Links

            has a non-specific relationship to

            Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-31253 META - web service improvements for 2.3

            • Critical - Crashes server, loss of data, severe memory leak
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Jérôme Mouneyrac added a comment -

              Another issue to peer-review Rosie Thank you

              Show
              Jérôme Mouneyrac added a comment - Another issue to peer-review Rosie Thank you
              Hide
              Permalink
              Rossiani Wijaya added a comment -

              Hi Jerome,

              The patch looks good.

              Thanks for fixing this.

              Show
              Rossiani Wijaya added a comment - Hi Jerome, The patch looks good. Thanks for fixing this.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Testing instructions, plz?

              Show
              Eloy Lafuente (stronk7) added a comment - Testing instructions, plz?
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Testing instructions, plz?

              Show
              Eloy Lafuente (stronk7) added a comment - Testing instructions, plz?
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              (Ops, sorry for dupe comment, I got an error and reloaded)

              Show
              Eloy Lafuente (stronk7) added a comment - (Ops, sorry for dupe comment, I got an error and reloaded)
              Hide
              Permalink
              Jérôme Mouneyrac added a comment -

              Instruction added

              Show
              Jérôme Mouneyrac added a comment - Instruction added
              Hide
              Permalink
              Aparup Banerjee added a comment -

              Thanks guys,
              thats been integrated into 21, 22 and master.

              Show
              Aparup Banerjee added a comment - Thanks guys, thats been integrated into 21, 22 and master.
              Hide
              Permalink
              Adrian Greeve added a comment -

              I tested this on versions 2.1, 2.2 and master. I checkout out master before hand to see what errors it was generating. I didn't come across any errors when adding functions to custom services.
              Test passed.

              Show
              Adrian Greeve added a comment - I tested this on versions 2.1, 2.2 and master. I checkout out master before hand to see what errors it was generating. I didn't come across any errors when adding functions to custom services. Test passed.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks!

              Closing as fixed, heading to zzzZZZzzz, niao

              Show
              Eloy Lafuente (stronk7) added a comment - It is late here and I'm very tired but I didn't want to go to sleep before expressing my admiration for your amazing collaboration. Thanks! Closing as fixed, heading to zzzZZZzzz, niao

                People

                • Votes:
                  2 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: