Moodle
  1. Moodle
  2. MDL-29519

Plagiarism API cron should be triggered after event queue

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      you can only really test this hasn't broken cron.

      a manual run of /admin/cron.php could be run to make sure that cron completes correctly.

      Show
      you can only really test this hasn't broken cron. a manual run of /admin/cron.php could be run to make sure that cron completes correctly.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      master_MDL-29519
    • Rank:
      19231

      Description

      The Plagiarism plugins use event handlers for some events like assignment created/deleted/updated.

      These events should be handled before the plugins try to use the assignments/modules in those events.

      we need to change the order of the plagiarism cron to happen after the event queue.

        Activity

        Hide
        Dan Marsden added a comment -

        NOTE FOR INTEGRATOR
        The master branch/commit will cherry-pick fine into 2.1stable and 2.0stable - happy for merge or cherry-pick

        Show
        Dan Marsden added a comment - NOTE FOR INTEGRATOR The master branch/commit will cherry-pick fine into 2.1stable and 2.0stable - happy for merge or cherry-pick
        Hide
        Michael de Raadt added a comment -

        Thanks for sharing that, Dan.

        Show
        Michael de Raadt added a comment - Thanks for sharing that, Dan.
        Hide
        Sam Hemelryk added a comment -

        Thanks Dan - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Dan - this has been integrated now
        Hide
        Ankit Agarwal added a comment -

        Hi,
        The cron completed successfully without any issues.
        Test passed.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi, The cron completed successfully without any issues. Test passed. Thanks
        Hide
        Aparup Banerjee added a comment -

        fixes have been rolled merrily up the stream! Thanks everybody!

        Show
        Aparup Banerjee added a comment - fixes have been rolled merrily up the stream! Thanks everybody!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: