Moodle
  1. Moodle
  2. MDL-29523

A hard coded string "Loading" in file manager element

    Details

    • Testing Instructions:
      Hide

      [Its not possible to really discover this improvement without problems with javascript allowing the existing to be displayed, so mostly we should test for regressions when loading the repository repository browser and ensure that the repository picker loads without problems

      Show
      [Its not possible to really discover this improvement without problems with javascript allowing the existing to be displayed, so mostly we should test for regressions when loading the repository repository browser and ensure that the repository picker loads without problems
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-29523-master
    • Rank:
      19000

      Description

      This is not an obvious problem. I found it just because occasionally javascript cache problem.

      Details in the diff link

        Activity

        Hide
        Michael de Raadt added a comment -

        Just to add some detail: the term Loading is hard-coded in the repository code rather than being gathered from a language file.

        Show
        Michael de Raadt added a comment - Just to add some detail: the term Loading is hard-coded in the repository code rather than being gathered from a language file.
        Hide
        Michael de Raadt added a comment -

        Thanks for providing a solution Sunner.

        Show
        Michael de Raadt added a comment - Thanks for providing a solution Sunner.
        Hide
        Dan Poltawski added a comment -

        I have reviewed this and it looks good, so submitting for integration. Thanks Sunner!

        Show
        Dan Poltawski added a comment - I have reviewed this and it looks good, so submitting for integration. Thanks Sunner!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (21, 22 & master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 & master)
        Hide
        Jason Fowler added a comment -

        File repos doesn't seem to have any issues

        Show
        Jason Fowler added a comment - File repos doesn't seem to have any issues
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Well,

        I wish I said it every time
        you do the things you do.
        You always lend a helping hand,
        and I'm filled with gratitude.

        You are strong and generous
        for each and everyone one of us.
        I am eternally grateful,
        I cannot say thanks enough.

        Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Well, I wish I said it every time you do the things you do. You always lend a helping hand, and I'm filled with gratitude. You are strong and generous for each and everyone one of us. I am eternally grateful, I cannot say thanks enough. Sorry for the (un)cool bit above, lol. Closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: