Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29528

typo in multichoice question upgrade from 1.9

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Questions
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      1. In a 1.9 site, create some multichoice questions with and without combined (overall) feedback.
      2. Upgrade this site to Moodle 2.x
      3. Verify that the combined feedback has been upgraded correctly.

      Also,

      1. In a 1.9 site, create some multichoice questions with and without combined (overall) feedback.
      2. Backup this course and restore it into a 2.1 site.
      3. Verify that the combined feedback has been upgraded correctly.

      Show
      1. In a 1.9 site, create some multichoice questions with and without combined (overall) feedback. 2. Upgrade this site to Moodle 2.x 3. Verify that the combined feedback has been upgraded correctly. Also, 1. In a 1.9 site, create some multichoice questions with and without combined (overall) feedback. 2. Backup this course and restore it into a 2.1 site. 3. Verify that the combined feedback has been upgraded correctly.
    • Workaround:
      Hide

      as this field was nonexistant in Moodle 1.9 there is not any risk of data loss and it is easy to fix this issue with a single sql query to correct already migrated questions

      Show
      as this field was nonexistant in Moodle 1.9 there is not any risk of data loss and it is easy to fix this issue with a single sql query to correct already migrated questions
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Hello, I just moticed all my multichoice questions upgraded from 1.9 to 2.1 have a 1 as content and Moodle as format.
      This seems to be caused by the line :
      $record->partiallycorrectfeedback = $record->oldquestiontextformat;
      in question/type/multichoice/db/upgrade.php line 121
      should be
      $record->partiallycorrectfeedbackformat = $record->oldquestiontextformat;

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Oct/11