Moodle
  1. Moodle
  2. MDL-29552

Usability: Show the name of the selected theme for each device

    Details

    • Testing Instructions:
      Hide
      • Enable $CFG->enabledevicedetection
      • Go to Admin -> Appearance -> Themes -> Theme selector
      • Over each "select theme" button, the name of the picked theme is shown (h3 heading).
      • Try picking themes for mobile / tablet / ... the name is shown once picked. Nothing is shown for device types without theme picked.
      • Note: it seems that you cannot "unselect" themes for devices. Ignore it. I've commented about that @ MDL-27862
      Show
      Enable $CFG->enabledevicedetection Go to Admin -> Appearance -> Themes -> Theme selector Over each "select theme" button, the name of the picked theme is shown (h3 heading). Try picking themes for mobile / tablet / ... the name is shown once picked. Nothing is shown for device types without theme picked. Note: it seems that you cannot "unselect" themes for devices. Ignore it. I've commented about that @ MDL-27862
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19031

      Description

      With $CFG->enabledevicedetection different themes for each device type can be selected. But once picked, the page misses information about which theme is the selected one. Only the screenshot gives you some clue about that.

      Ideally the name of the selected theme should be shown over the "select theme" button (exactly the same way that in the list of themes picker).

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Assigned to me and triaged to DEV backlog. I've one working patch here already.

          Show
          Eloy Lafuente (stronk7) added a comment - Assigned to me and triaged to DEV backlog. I've one working patch here already.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Submitting to integration.

          Note for integrators: Although it's an improvement, it is trivial and applies clean to 21_STABLE, so for your consideration to cherry-pick it there.

          Show
          Eloy Lafuente (stronk7) added a comment - Submitting to integration. Note for integrators: Although it's an improvement, it is trivial and applies clean to 21_STABLE, so for your consideration to cherry-pick it there.
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and cheers!

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and cheers!
          Hide
          Sam Hemelryk added a comment -

          Thanks Eloy - this has been integrated and has been cherry-picked to 21 as well (it makes things a lot more obvious and could certainly be considerers a usability bug )

          Show
          Sam Hemelryk added a comment - Thanks Eloy - this has been integrated and has been cherry-picked to 21 as well (it makes things a lot more obvious and could certainly be considerers a usability bug )
          Hide
          Ankit Agarwal added a comment -

          Hi,
          works as expected.
          Thanks

          Show
          Ankit Agarwal added a comment - Hi, works as expected. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          git repositories have been updated with your awesome changes, thanks! Closing.

          Show
          Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: