Moodle
  1. Moodle
  2. MDL-29564

Fatal error: Call to undefined function plagiarism_get_links()

    Details

    • Database:
      MySQL
    • Testing Instructions:
      Hide

      1. As a teacher Create an "Upload a single file" assignment type using the default settings
      2. As a student upload a file to the newly created assignment.
      3. As the teacher view the submitted assignments
      4. Next as the teacher click on the name of the student who uploaded the file.
      5. In the navigation block browse to Coursename -> Participants -> StudentName -> Activity Reports -> complete report

      Verify the report is generated completely

      Show
      1. As a teacher Create an "Upload a single file" assignment type using the default settings 2. As a student upload a file to the newly created assignment. 3. As the teacher view the submitted assignments 4. Next as the teacher click on the name of the student who uploaded the file. 5. In the navigation block browse to Coursename -> Participants -> StudentName -> Activity Reports -> complete report Verify the report is generated completely
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:

      Description

      Assignments using the Upload a single file type generate a fatal error when viewed on the User completion report

      Steps to reproduce: (This requires two users one assigned the teacher role, the other assigned the student role)

      1. On the test server disable both the plagiarism plugins and portfolios from Site Administration ->Advanced Features.
      2. Set debugging to developer and display errors to yes at Site Administration -> Development ->Debugging
      3. As a teacher Create an "Upload a single file" assignment type using the default settings
      4. As a student upload a file to the newly created assignment.
      5. As the teacher view the submitted assignments
      6. Next as the teacher click on the name of the student who uploaded the file.
      7. In the navigation block browse to Coursename -> Participants -> StudentName -> Activity Reports -> complete report

      Expected result: The complete activity report is displayed
      Actual result: The activity report is generated up to the upload a single file entry. The error "Fatal error: Call to undefined function plagiarism_get_links() in C:\WebSites\Moodle\moodle21\mod\assignment\lib.php on line 1927" is displayed

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Stephen Bourget added a comment - - edited

            Attached a patch to fix this bug

            Show
            Stephen Bourget added a comment - - edited Attached a patch to fix this bug
            Hide
            Michael de Raadt added a comment -

            Thanks for such an excellent report and for providing a patch. Top work!

            Show
            Michael de Raadt added a comment - Thanks for such an excellent report and for providing a patch. Top work!
            Hide
            Stephen Bourget added a comment -

            Dan,

            It looks like you wrote most of the code for the Plagiarism api. Can you peer review this code?

            Thanks

            Show
            Stephen Bourget added a comment - Dan, It looks like you wrote most of the code for the Plagiarism api. Can you peer review this code? Thanks
            Hide
            Dan Marsden added a comment -

            Looks good to me - thanks Stephen!

            NOTE TO INTEGRATOR:
            This needs to be applied to 20Stable, 21Stable and Master - the above patch from Stephen:
            b801633a9ca990b3930f1e37ae6bc28c63c387aa

            applies cleanly to all current branches.

            thanks!

            Show
            Dan Marsden added a comment - Looks good to me - thanks Stephen! NOTE TO INTEGRATOR: This needs to be applied to 20Stable, 21Stable and Master - the above patch from Stephen: b801633a9ca990b3930f1e37ae6bc28c63c387aa applies cleanly to all current branches. thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Sam Hemelryk added a comment -

            Thanks guys - this has been integrated now on 20, 21, and master

            Show
            Sam Hemelryk added a comment - Thanks guys - this has been integrated now on 20, 21, and master
            Hide
            Jason Fowler added a comment -

            Tested in Integration 2.0, 2.1 and Master, all working fine

            Show
            Jason Fowler added a comment - Tested in Integration 2.0, 2.1 and Master, all working fine
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: