Moodle
  1. Moodle
  2. MDL-29570

Quiz editing page displays the wrong time in the status line

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      For quizzes wiht
      A. No open or close date
      B. Open date but no close date.
      C. Close date but not open date.
      D. Both an open and a close date.

      And for time before / after the open / close date(s) (so, that is is a total of 8 scenarios to check, 1 + 2 + 2 + 3)

      Look at the status line on the quiz editing page, and make sure that the date information displayed, and in the tool-tip, is sensible.

      Show
      For quizzes wiht A. No open or close date B. Open date but no close date. C. Close date but not open date. D. Both an open and a close date. And for time before / after the open / close date(s) (so, that is is a total of 8 scenarios to check, 1 + 2 + 2 + 3) Look at the status line on the quiz editing page, and make sure that the date information displayed, and in the tool-tip, is sensible.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      19439

      Description

      There is a place where it outputs timeclose when it should be timeopen.

      See this forum thread: http://moodle.org/mod/forum/discuss.php?d=186725

        Activity

        Hide
        Joseph Rézeau added a comment -

        Tested on Moodle 2.1.1+ (Build: 20110928) with patch from https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-29570_21

        everything OK

        A. No open or close date / OK

        B. Open date but no close date.
        a. open date before now: OK
        b. open date after now: ok

        C. Close date but no open date.
        a. close date before now: OK
        b. close date after now: ok

        D. Both an open and a close date.
        a. open date before now and close date after now: ok
        b. open date before now and close date before now: ok
        c. open date after now and close date after now: ok

        Show
        Joseph Rézeau added a comment - Tested on Moodle 2.1.1+ (Build: 20110928) with patch from https://github.com/timhunt/moodle/compare/MOODLE_21_STABLE...MDL-29570_21 everything OK A. No open or close date / OK B. Open date but no close date. a. open date before now: OK b. open date after now: ok C. Close date but no open date. a. close date before now: OK b. close date after now: ok D. Both an open and a close date. a. open date before now and close date after now: ok b. open date before now and close date before now: ok c. open date after now and close date after now: ok
        Hide
        Tim Hunt added a comment -

        Thank you for testing this so carefully Joseph.

        Show
        Tim Hunt added a comment - Thank you for testing this so carefully Joseph.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Ankit Agarwal added a comment -

        Hi,
        Works as expected.
        Thanks

        Show
        Ankit Agarwal added a comment - Hi, Works as expected. Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        git repositories have been updated with your awesome changes, thanks! Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: